cmd/go: handle ldflag escapes in pkg-config output

[raphi011]

What version of Go are you using (go version)?

$ go version
go version go1.12.9 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/raphi/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/raphi/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/golang"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/raphi/code/go/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build148444745=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Attempt to build a cgo binary with pkg-config containing ldflags with a whitespace.

What did you expect to see?

A successfull build.

What did you see instead?

go build github.com/ElektraInitiative/go-elektra/kdb: invalid flag in pkg-config --libs: elektra/build/lib

PR: #34709

Relates to

• cmd/go: handle pkg-config output containing spaces #16455
• cmd/cgo: ldflags directive doesn't like empty spaces in paths #7906

[onefy502]

ok

[katiehockman]

/cc @bcmills @jayconrod

CL in Gerrit: https://go-review.googlesource.com/c/go/+/199337

[matloob]

Is this still happening?

[gopherbot]

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)