cmd/go: invalid flag in #cgo LDFLAGS: -zcommon-page-size=2097152

[hailingluo]

What version of Go are you using (go version)?

$ go version
go version go1.16.5 linux/arm64

What operating system and processor architecture are you using (go env)?

go env Output

$ go env

What did you do?

number_main.go

go build -buildmode=pie -ldflags='-v -linkmode=internal' number_main.go

What did you expect to see?

build successfully

What did you see instead?

go build command-line-arguments: invalid flag in #cgo LDFLAGS: -zcommon-page-size=2097152

[bcmills]

There is an explicit list of allowed flags in cmd/go/internal/work/security.go.

-zcommon-page-size and -zmax-page-size seem safe to add to that list — it appears that -z execstack and -z relro are already accepted — but I will defer to @ianlancetaylor for the final call.

[ianlancetaylor]

Yes, those flags are fine. Want to send a patch for the 1.19 release? Thanks.

[hailingluo]

I have added these two flags into my local go version (1.16.5) and it works.

[matloob]

@hailingluo Are you interested in sending a patch for this?

[gopherbot]

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)