x/tools/gopls/internal/regtest/watch: failures in TestDeleteFiles

[bcmills]

--- FAIL: TestDeleteFiles (7.39s)
    --- FAIL: TestDeleteFiles/delete_then_close (2.00s)
        --- FAIL: TestDeleteFiles/delete_then_close/singleton (0.35s)
            watch_test.go:429: waiting on:
                	Unmeetable: once "completed work \"diagnosing opened files\" at least 2 time(s)" is met, must have "log message matching \"a_unneeded.go\" expected 1 times"
                
                err:condition has final verdict Unmeetable
                
                state:
                #### log messages (see RPC logs for full text):
                	Info: "2022/03/16 01:47:26 go env for /tmp/workdir/tmp/go...
                	Info: "2022/03/16 01:47:26 40.756228ms for GOROOT=/tmp/wo...
                	Info: "2022/03/16 01:47:26 87.117632ms for GOROOT=/tmp/wo...
                	Info: "2022/03/16 01:47:26 go/packages.Load\n\tsnapshot=0...
                	Info: "2022/03/16 01:47:26 go/packages.Load\n\tsnapshot=0...
                	Info: "2022/03/16 01:47:26 85.280814ms for GOROOT=/tmp/wo...
                
                #### diagnostics:
                
                #### outstanding work:
                #### completed work:
                	Load: 1
                	Setting up workspace: 1
                	diagnosing initial workspace load: 1
                	diagnosing opened files: 2
FAIL
FAIL	golang.org/x/tools/gopls/internal/regtest/watch	26.318s

greplogs --dashboard -md -l -e 'FAIL: TestDeleteFiles' --omit=openbsd-.\*-n2d\|dragonfly-amd64 --since=2022-01-01

2022-03-16T01:41:57-77aa08b-4aa1efe/freebsd-amd64-12_3
2022-01-18T18:56:51-f29bdf1-75bcdd5/windows-arm64-10
2022-01-12T19:47:40-d7a4bb4-f005df8/windows-arm64-10
2022-01-07T22:46:47-94bfe68-7f3eb61/netbsd-amd64-9_0-n1

(CC @findleyr)

[bcmills]

greplogs --dashboard -md -l -e 'FAIL: TestDeleteFiles' --since=2022-03-17
2022-05-23T18:40:59-ccb1050-74f0ccb/netbsd-amd64-9_0
2022-04-04T10:59:27-153e30b-1af60b2/windows-amd64-race
2022-04-04T04:04:18-153e30b-884e75f/windows-amd64-longtest
2022-03-22T20:46:22-1428e83-817d6ea/netbsd-386-9_0

(Note that although windows/amd64 is a first-class port, the two windows/amd64 failures above were fallout from CL 367495, which was subsequently reverted.)

[bcmills]

Recent unattributed failures seem to be mostly (or entirely?) on NetBSD. 🤔

(CC @golang/netbsd)

greplogs --dashboard -md -l -e 'FAIL: TestDeleteFiles' --since=2022-05-24
2022-05-27T15:13:07-0e859af-42f1b37/netbsd-amd64-9_0

[findleyr]

Another failure that can plausibly be explained by my misunderstanding of log sequencing.

[gopherbot]

Change https://go.dev/cl/513097 mentions this issue: gopls: fix tests that depend on log sequencing