Skip to content

gopls/internal/regtest: use a real file system notifier #52284

Open
@findleyr

Description

@findleyr

It looks like several gopls testing flakes may be related to inaccurate file system notifications (e.g. #51930).

Historically, the gopls regtests had executed in the x/tools module, and so could not import cross platform libraries for filesystem notifications (e.g. https://github.com/fsnotify/fsnotify). To work around this, file watching is 'faked' via polling.

The regtests are now in x/tools/gopls, and we should consider replacing this polling with an actual notification library. This would theoretically reduce flakes and improve accuracy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    TestingAn issue that has been verified to require only test changes, not just a test failure.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions