Skip to content

x/tools/gopls/internal/regtest/workspace: TestQuickFix_AddGoWork fails with released go 1.21+ #61307

@hyangah

Description

@hyangah
Contributor

Go version go1.21rc2

The behavior of the go command is changing, and the test needs fixing to work with go1.21+.

#### End Gopls Test Logs for "TestQuickFix_AddGoWork/use_all/experimental"
--- FAIL: TestQuickFix_AddGoWork (22.95s)
    --- FAIL: TestQuickFix_AddGoWork/use_b (8.02s)
        --- FAIL: TestQuickFix_AddGoWork/use_b/default (3.05s)
            quickfix_test.go:208: unexpected go.work content:
                --- want
                +++ got
                @@ -1,4 +1,4 @@
                -go 1.21
                +go 1.21rc2
                 
                 use ./b
...
FAIL
FAIL    golang.org/x/tools/gopls/internal/regtest/workspace     233.461s

Activity

added
goplsIssues related to the Go language server, gopls.
on Jul 11, 2023
added this to the gopls/v0.12.5 milestone on Jul 11, 2023
added
ToolsThis label describes issues relating to any tools in the x/tools repository.
on Jul 11, 2023
gopherbot

gopherbot commented on Jul 11, 2023

@gopherbot
Contributor

Change https://go.dev/cl/508801 mentions this issue: gopls/internal/regtest/workspace: fix TestQuickFix_AddGoWork for go1.21

added a commit that references this issue on Feb 16, 2024
a721062
locked and limited conversation to collaborators on Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @hyangah@gopherbot

        Issue actions

          x/tools/gopls/internal/regtest/workspace: TestQuickFix_AddGoWork fails with released go 1.21+ · Issue #61307 · golang/go