-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Closed
Labels
FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.
Milestone
Description
Go version go1.21rc2
The behavior of the go command is changing, and the test needs fixing to work with go1.21+.
#### End Gopls Test Logs for "TestQuickFix_AddGoWork/use_all/experimental"
--- FAIL: TestQuickFix_AddGoWork (22.95s)
--- FAIL: TestQuickFix_AddGoWork/use_b (8.02s)
--- FAIL: TestQuickFix_AddGoWork/use_b/default (3.05s)
quickfix_test.go:208: unexpected go.work content:
--- want
+++ got
@@ -1,4 +1,4 @@
-go 1.21
+go 1.21rc2
use ./b
...
FAIL
FAIL golang.org/x/tools/gopls/internal/regtest/workspace 233.461s
Metadata
Metadata
Assignees
Labels
FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.
Type
Projects
Relationships
Development
Select code repository
Activity
gopherbot commentedon Jul 11, 2023
Change https://go.dev/cl/508801 mentions this issue:
gopls/internal/regtest/workspace: fix TestQuickFix_AddGoWork for go1.21
gopls/internal/regtest/workspace: fix TestQuickFix_AddGoWork for go1.21