net/http: TestTransportNoReuseAfterEarlyResponse failures due to leaked transports

[gopherbot]

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportNoReuseAfterEarlyResponse" && `appears to have leaked a Transport`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportNoReuseAfterEarlyResponse (2.62s)
    --- FAIL: TestTransportNoReuseAfterEarlyResponse/h1 (2.62s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x56d7d7f8?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000288800)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:113 +0x65
            net.(*netFD).Close(0xc000288800)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc000692008)
...
            testing.(*T).Run(0xc000a09860, {0xf98d51f?, 0xf64c56d?}, 0xc0002d8060)
            	/tmp/buildlet/go/src/testing/testing.go:1736 +0x3ab
            net/http_test.run[...](0xc000a09860, 0xfb220b0, {0xc0004ba740, 0x2?, 0x183e44b0})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x283
            net/http_test.TestTransportNoReuseAfterEarlyResponse(0xc000a09860)
            	/tmp/buildlet/go/src/net/http/transport_test.go:3490 +0x9c
            testing.tRunner(0xc000a09860, 0xfb20d38)
            	/tmp/buildlet/go/src/testing/testing.go:1682 +0xfb
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1735 +0x390

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net/http" && test == "TestTransportNoReuseAfterEarlyResponse"

2023-11-17 18:12 darwin-amd64-longtest go@a9722bf9 net/http.TestTransportNoReuseAfterEarlyResponse (log)

--- FAIL: TestTransportNoReuseAfterEarlyResponse (2.62s)
    --- FAIL: TestTransportNoReuseAfterEarlyResponse/h1 (2.62s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x56d7d7f8?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000288800)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:113 +0x65
            net.(*netFD).Close(0xc000288800)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc000692008)
...
            testing.(*T).Run(0xc000a09860, {0xf98d51f?, 0xf64c56d?}, 0xc0002d8060)
            	/tmp/buildlet/go/src/testing/testing.go:1736 +0x3ab
            net/http_test.run[...](0xc000a09860, 0xfb220b0, {0xc0004ba740, 0x2?, 0x183e44b0})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x283
            net/http_test.TestTransportNoReuseAfterEarlyResponse(0xc000a09860)
            	/tmp/buildlet/go/src/net/http/transport_test.go:3490 +0x9c
            testing.tRunner(0xc000a09860, 0xfb20d38)
            	/tmp/buildlet/go/src/testing/testing.go:1682 +0xfb
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1735 +0x390

— watchflakes

[bcmills]

(attn @neild)

See previously:

• net/http: TestRequestBodyLimit failures due to leaked Transports #60264
• net/http: "Test appears to have leaked a Transport" on darwin-amd64-longtest #59526

[gopherbot]

Change https://go.dev/cl/546616 mentions this issue: net/http: avoid leaking io.Copy goroutines (and hijacked connections) in TestTransportNoReuseAfterEarlyResponse

[bcmills]

Still leaky, unfortunately:
https://build.golang.org/log/12dcbefd8ecb13277446cbefd331ec5773428bd3

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportNoReuseAfterEarlyResponse" && `appears to have leaked a Transport`

2024-01-03 21:01 darwin-amd64-longtest go@6db11026 net/http.TestTransportNoReuseAfterEarlyResponse (log)

--- FAIL: TestTransportNoReuseAfterEarlyResponse (2.64s)
    --- FAIL: TestTransportNoReuseAfterEarlyResponse/h1 (2.64s)
        main_test.go:161: Test appears to have leaked a Transport:
            internal/poll.runtime_Semacquire(0x57dc13c8?)
            	/tmp/buildlet/go/src/runtime/sema.go:67 +0x25
            internal/poll.(*FD).Close(0xc000214900)
            	/tmp/buildlet/go/src/internal/poll/fd_unix.go:113 +0x65
            net.(*netFD).Close(0xc000214900)
            	/tmp/buildlet/go/src/net/fd_posix.go:37 +0x32
            net.(*conn).Close(0xc000056040)
...
            testing.(*T).Run(0xc00047eb60, {0x10aa969f?, 0x10e426c8?}, 0xc0004fe060)
            	/tmp/buildlet/go/src/testing/testing.go:1750 +0x3ab
            net/http_test.run[...](0xc00047eb60, 0x10c439d8, {0xc000356f40, 0x2, 0x32fda660})
            	/tmp/buildlet/go/src/net/http/clientserver_test.go:82 +0x269
            net/http_test.TestTransportNoReuseAfterEarlyResponse(0xc00047eb60)
            	/tmp/buildlet/go/src/net/http/transport_test.go:3490 +0x9c
            testing.tRunner(0xc00047eb60, 0x10c42660)
            	/tmp/buildlet/go/src/testing/testing.go:1689 +0xfb
            created by testing.(*T).Run in goroutine 1
            	/tmp/buildlet/go/src/testing/testing.go:1742 +0x390

— watchflakes