net: TestClosingListener failures

[gopherbot]

#!watchflakes
default <- pkg == "net" && test == "TestClosingListener"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestClosingListener
    listen_test.go:721: listen tcp 127.0.0.1:64395: bind: address already in use
--- FAIL: TestClosingListener (0.00s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestClosingListener"

2024-02-26 20:45 gotip-solaris-amd64 go@08029be9 net.TestClosingListener (log)

=== RUN   TestClosingListener
    listen_test.go:721: listen tcp 127.0.0.1:64395: bind: address already in use
--- FAIL: TestClosingListener (0.00s)

— watchflakes

[bcmills]

This is a race in the test itself. It closes a Listener and tries to start listening on the same address again, but nothing guarantees that the port isn't reused by some other test in between those two steps.

(attn @ianlancetaylor @neild)

[bcmills]

One simple fix is to delete the test, since it is inherently racy. 🤷‍♂️

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "net" && test == "TestClosingListener"

2025-02-11 16:21 gotip-solaris-amd64 go@887d9ef6 net.TestClosingListener (log)

=== RUN   TestClosingListener
    listen_test.go:721: listen tcp 127.0.0.1:49753: bind: address already in use
--- FAIL: TestClosingListener (0.00s)

— watchflakes