x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer

[adonovan]

#!stacks
"crash/crash" && "analysisinternal.ZeroValue:+18"

Issue created by stacks.

This stack AX6IMQ was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• golang.org/x/tools/internal/analysisinternal.ZeroValue:+18
• golang.org/x/tools/gopls/internal/golang.adjustReturnStatements:+9
• golang.org/x/tools/gopls/internal/golang.extractFunctionMethod:+300
• golang.org/x/tools/gopls/internal/golang.extractFunction:+1
• golang.org/x/tools/gopls/internal/golang.ApplyFix.singleFile.func3:+1
• golang.org/x/tools/gopls/internal/golang.ApplyFix:+41
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ApplyFix.func1:+1
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run.func2:+3
• golang.org/x/tools/gopls/internal/server.(*commandHandler).run:+77
• golang.org/x/tools/gopls/internal/server.(*commandHandler).ApplyFix:+2
• golang.org/x/tools/gopls/internal/protocol/command.Dispatch:+31
• golang.org/x/tools/gopls/internal/server.(*server).ResolveCodeAction:+21
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+46
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52

golang.org/x/tools/gopls@v0.17.0-pre.2 go1.23.3 linux/amd64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: crash in Hover (telemetry) #69362
• x/tools/gopls: automated issue report (crash) #40449 (closed)
• x/tools/gopls: crash in mapPosition computing OutgoingCalls to unsafe.Slice #66923 (closed)
• x/tools/gopls: automated issue report (crash) #40819 (closed)
• x/tools/internal/imports: invalid memory address or nil pointer dereference (crash) #57622 (closed)
• x/tools/gopls: Hover: panic in lookupObjectByName #69616
• x/tools/gopls: "slice bounds out of range" crash in ExtractToNewFile #70553
• x/tools/gopls: automated issue report (crash) - unhandled basic type #40956 (closed)
• x/tools/gopls: automated issue report (crash) #44300 (closed)
• x/tools/gopls: crash in packageReferences (reported by telemetry) #66250 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

By chance, I think @h9jiang just fixed this in https://go.dev/cl/627604!