Skip to content

x/tools/gopls: stubmethods: nil deref of FuncType.Results in fromReturnStmt #70967

Closed
@adonovan

Description

@adonovan
Member

Activity

added
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
goplsIssues related to the Go language server, gopls.
ToolsThis label describes issues relating to any tools in the x/tools repository.
on Dec 23, 2024
added this to the Unreleased milestone on Dec 23, 2024
adonovan

adonovan commented on Dec 23, 2024

@adonovan
MemberAuthor

I think this was fixed in passing by https://go.dev/cl/623156 which changed it to:

	rets := sig.Results()
	// The return operands and function results must match.
	// (Spread returns were rejected earlier.)
	if rets.Len() != len(ret.Results) {
		return nil, fmt.Errorf("%d-operand return statement in %d-result function",
			len(ret.Results),
			rets.Len())
	}
adonovan

adonovan commented on Dec 30, 2024

@adonovan
MemberAuthor

Presumed fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.gopls/telemetry-wins

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @adonovan@gopherbot@findleyr@gabyhelp

        Issue actions

          x/tools/gopls: stubmethods: nil deref of FuncType.Results in fromReturnStmt · Issue #70967 · golang/go