x/tools/gopls: Rename: "no type for %T" panic in satisfy

[adonovan]

#!stacks
"runtime.gopanic" && "satisfy.(*Finder).expr:+168"

Issue created by stacks.

This means satisfy was called on ill-typed code. As with #71538, the long-term remedy here is to get rid of the satisfy package and use #70638 instead.

This stack _KFIag was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+168
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+149
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+148
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+97
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+100
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90
• golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19
• golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27
• golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178
• golang.org/x/tools/gopls/internal/golang.(*renamer).check:+16
• golang.org/x/tools/gopls/internal/golang.renameObjects:+24
• golang.org/x/tools/gopls/internal/golang.renameExported:+56
• golang.org/x/tools/gopls/internal/golang.renameOrdinary:+157
• golang.org/x/tools/gopls/internal/golang.Rename:+24
• golang.org/x/tools/gopls/internal/server.(*server).Rename:+17

golang.org/x/tools/[email protected] go1.24rc2 darwin/arm64 vscode (2)

Dups: fHpkWA zggtYA 9iXGhQ

[gabyhelp]

Related Issues

• x/tools/gopls: Rename: "unexpected composite literal type %T: %v" panic in satisfy.(*Finder).Find #71538
• x/tools/gopls: Rename: crash due to Info.Defs[id]=nil bug in checkStructField #70968
• x/tools/gopls: crash when renaming in a package using builtins with type parameters #52940 (closed)
• x/tools/gopls: Completion: failed type assertion in completer.item #71044 (closed)
• go/types: panic("t.fromRHS = %s, typ = %s") in setDefType #71029
• x/tools/gopls: gopls fails to rename all uses of instantiated struct field #61640 (closed)
• x/tools/gopls: rename fails on struct method that references bad struct field #32882 (closed)
• x/tools/gopls: "edit does not belong to syntax of package %q" bug in golang.Rename #70049
• x/tools/gopls: crash during renaming #53277 (closed)
• x/tools/gopls: completion: failed type assertion in inferExpectedTypeArg #70889 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

This stack fHpkWA was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+168
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+97
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90
• golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19
• golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27
• golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178
• golang.org/x/tools/gopls/internal/golang.(*renamer).check:+16
• golang.org/x/tools/gopls/internal/golang.renameObjects:+24
• golang.org/x/tools/gopls/internal/golang.renameExported:+56
• golang.org/x/tools/gopls/internal/golang.renameOrdinary:+157
• golang.org/x/tools/gopls/internal/golang.Rename:+24
• golang.org/x/tools/gopls/internal/server.(*server).Rename:+17
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+489
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52

golang.org/x/tools/[email protected] go1.24.0 darwin/amd64 other,vscode (1)

[adonovan]

This stack zggtYA was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+168
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+75
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90
• golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19
• golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27
• golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178
• golang.org/x/tools/gopls/internal/golang.(*renamer).check:+16
• golang.org/x/tools/gopls/internal/golang.renameObjects:+24
• golang.org/x/tools/gopls/internal/golang.renameExported:+56
• golang.org/x/tools/gopls/internal/golang.renameOrdinary:+157
• golang.org/x/tools/gopls/internal/golang.Rename:+24
• golang.org/x/tools/gopls/internal/server.(*server).Rename:+17
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+489
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52

golang.org/x/tools/[email protected] go1.24.1 linux/amd64 vscode (2)

[adonovan]

This stack 9iXGhQ was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• golang.org/x/tools/refactor/satisfy.(*Finder).expr:+168
• golang.org/x/tools/refactor/satisfy.(*Finder).call:+26
• golang.org/x/tools/refactor/satisfy.(*Finder).exprN:+9
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+35
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+204
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90
• golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19
• golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27
• golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178
• golang.org/x/tools/gopls/internal/golang.(*renamer).check:+16
• golang.org/x/tools/gopls/internal/golang.renameObjects:+24
• golang.org/x/tools/gopls/internal/golang.renameExported:+56
• golang.org/x/tools/gopls/internal/golang.renameOrdinary:+157
• golang.org/x/tools/gopls/internal/golang.Rename:+24

golang.org/x/tools/[email protected] go1.24.1 darwin/arm64 vscode (2)