Skip to content

runtime: -race data race map traceback report incorrect functions [1.24 backport] #73192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 7, 2025 · 2 comments
Closed

runtime: -race data race map traceback report incorrect functions [1.24 backport] #73192

gopherbot opened this issue Apr 7, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.24.3

Comments

@gopherbot
Copy link
Contributor

@prattmic requested issue #73191 to be considered for backport to the next 1.24 minor release.

@gopherbot Please backport to 1.24. This is a minor issue. DATA RACE reports for races in fast-variant maps (int or string keys) will report the wrong map function (e.g., mapassign vs mapassign_fast32). This is a reporting issue only that may cause confusion for readers, as it seems to be an "impossible" call that doesn't appear in the assembly. The most confusing one is map delete, which will report as map assign. This only affects GOTRACEBACK=system or higher because we otherwise hide the runtime function anyway.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 7, 2025
@gopherbot gopherbot mentioned this issue Apr 7, 2025
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 7, 2025
@gopherbot gopherbot added this to the Go1.24.3 milestone Apr 7, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/663777 mentions this issue: [release-branch.go1.24] internal/runtime/maps: pass proper func PC to race.WritePC/race.ReadPC

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Apr 16, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 16, 2025
gopherbot pushed a commit that referenced this issue Apr 28, 2025
@mateusz834 @gopherbot
[release-branch.go1.24] internal/runtime/maps: pass proper func PC to…
56eb998 
… race.WritePC/race.ReadPC

Fixes #73192
For #73191

Change-Id: I0f8a5a19faa745943a98476c7caf4c97ccdce184
Reviewed-on: https://go-review.googlesource.com/c/go/+/663175
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
Auto-Submit: Michael Pratt <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
(cherry picked from commit 14b15a2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/663777
Reviewed-by: Carlos Amedee <[email protected]>
Auto-Submit: Junyang Shao <[email protected]>
Reviewed-by: Junyang Shao <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 663777 (commit 56eb998) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.24.3
Development

No branches or pull requests
2 participants
@prattmic @gopherbot