Skip to content

cmd/go: +dirty in version stamping doesn't combine well with +incompatible [1.24 backport] #73500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 25, 2025 · 2 comments
Closed

cmd/go: +dirty in version stamping doesn't combine well with +incompatible [1.24 backport] #73500

gopherbot opened this issue Apr 25, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.24.3

Comments

@gopherbot
Copy link
Contributor

@xnox requested issue #71971 to be considered for backport to the next 1.24 minor release.

@gopherbot please backport to Go 1.24. This bug is producing unparsable buildinfo for compliant validators.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Apr 25, 2025
@gopherbot gopherbot mentioned this issue Apr 25, 2025
Closed
@gopherbot gopherbot added this to the Go1.24.3 milestone Apr 25, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/668135 mentions this issue: [release-branch.go1.24] cmd/go/internal/load: join incompatible and dirty build specifiers with .

@xnox xnox mentioned this issue Apr 25, 2025
Closed
@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 25, 2025
gopherbot pushed a commit that referenced this issue Apr 28, 2025
@xnox @cagedmantis
[release-branch.go1.24] cmd/go/internal/load: join incompatible and d…
c1f9c2c 
…irty build specifiers with .

Change "+incompatible+dirty" version to be "+incompatible.dirty" such
that it is SemVer spec compatible.

Fixes #73500

Change-Id: I714ffb3f1ad88c793656c3652367db34739a2144
Reviewed-on: https://go-review.googlesource.com/c/go/+/652955
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Sam Thanawalla <[email protected]>
Reviewed-by: Sean Liao <[email protected]>
Auto-Submit: Sean Liao <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
(cherry picked from commit a6e7445)
Reviewed-on: https://go-review.googlesource.com/c/go/+/668135
@gopherbot
Copy link
Contributor Author

Closed by merging CL 668135 (commit c1f9c2c) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.24.3
Development

No branches or pull requests
2 participants
@gopherbot @matloob