x/tools/gopls: modernize slices.Delete suggestion not considering uint type

[anderseknert]

gopls version

v0.18.1

go env

-

What did you do?

package main

import "fmt"

func main() {
	var s = []string{"a", "b", "c"}
	var i uint32 = 1

	s = append(s[:i], s[i+1:]...)

	fmt.Println(s) // [a c]
}

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix ./...

What did you see happen?

package main

import "slices"

import "fmt"

func main() {
	var s = []string{"a", "b", "c"}
	var i uint32 = 1

	s = slices.Delete(s, i, i+1)

	fmt.Println(s)
}

go build
./main.go:11:23: cannot use i (variable of type uint32) as int value in argument to slices.Delete
./main.go:11:26: cannot use i + 1 (value of type uint32) as int value in argument to slices.Delete

What did you expect to see?

That the change wasn't suggested in this case (or possibly with a cast to make it work? I haven't thought much about that).

This issue also encountered when running modernize against OPA, specifically here.

Editor and settings

No response

Logs

No response

[gabyhelp]

Related Issues

• x/tools/gopls: modernize slices.Clone suggestion wrong when copying between aliased types #73661
• x/tools/gopls/internal/analysis/modernize: slicedelete: triggers on non idempotent slice identifiers #72955 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[xieyuschen]

Thanks for reporting the issue. I believe modernizer needs to check untyped type additionally, so after applying fixes, it won't cause type-check errors. I will send a fix with the similar approach in CL-665195.

[gopherbot]

Change https://go.dev/cl/671735 mentions this issue: gopls/internal/analysis/modernize/slicesdelete: convert index type if needed

[gopherbot]

Change https://go.dev/cl/671975 mentions this issue: gopls/internal/analysis/modernize: preserve return type of append