Skip to content

runtime: memlock not unlocked in all control flow paths in sysReserveAlignedSbrk [1.24 backport] #74346

New issue
New issue
Closed
Closed
runtime: memlock not unlocked in all control flow paths in sysReserveAlignedSbrk [1.24 backport]#74346
Labels
CherryPickApprovedUsed during the release process for point releasescompiler/runtimeIssues related to the Go compiler and/or runtime.
Milestone
Go1.24.5
@gopherbot

Description

@gopherbot
gopherbot
opened on Jun 23, 2025
Contributor

@cherrymui requested issue #74339 to be considered for backport to the next 1.24 minor release.

@gopherbot please backport this to Go 1.24. This could potentially cause a deadlock. The fix is obviously safe. Thanks.

(1.24 only as sysReserveAlignedSbrk is new code in 1.24.)

Activity

gopherbot
added
CherryPickCandidateUsed during the release process for point releases
on Jun 23, 2025
gopherbot
mentioned this on Jun 23, 2025
gopherbot
added
compiler/runtimeIssues related to the Go compiler and/or runtime.
on Jun 23, 2025
gopherbot
added this to the Go1.24.5 milestone on Jun 23, 2025
gopherbot

gopherbot commented on Jun 25, 2025

@gopherbot
gopherbot
on Jun 25, 2025
ContributorAuthor

Change https://go.dev/cl/684016 mentions this issue: [release-branch.go1.24] runtime: add missing unlock in sysReserveAlignedSbrk

dmitshur
added
CherryPickApprovedUsed during the release process for point releases
and removed
CherryPickCandidateUsed during the release process for point releases
on Jun 25, 2025
gopherbot
added a commit that references this issue on Jun 25, 2025

[release-branch.go1.24] runtime: add missing unlock in sysReserveAlig…

1575127
gopherbot

gopherbot commented on Jun 25, 2025

@gopherbot
gopherbot
on Jun 25, 2025
ContributorAuthor

Closed by merging CL 684016 (commit 1575127) to release-branch.go1.24.

gopherbot
closed this as completedon Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CherryPickApprovedUsed during the release process for point releasescompiler/runtimeIssues related to the Go compiler and/or runtime.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dmitshur@gopherbot

        Issue actions
          runtime: memlock not unlocked in all control flow paths in sysReserveAlignedSbrk [1.24 backport] · Issue #74346 · golang/go