Order of calls is enforced when `InOrder()` or `After()` were not invoked

[alexykot]

Actual behaviour
When I have EXPECT set for two calls to the same method with different parameters - the order of EXPECT definitions enforces the order of the actual calls.

I.e. when having these expectations defined:

    test.mock.EXPECT().DoSomething("foo").Return(&Response{})
    test.mock.EXPECT().DoSomething("bar").Return(&Response{})

and code under test defined as

    service.DoSomething("foo")
    service.DoSomething("bar")

Just changing the order of definitions of calls expected with no other changes, i.e. making it

test.mock.EXPECT().DoSomething("bar").Return(&Response{})
test.mock.EXPECT().DoSomething("foo").Return(&Response{})

makes the test fail.

Expected behavior
As per documentation:

By default, expected calls are not enforced to run in any particular order.

So no order should be enforced as long as the actual calls match any of the defined expectations.

Additional Information

• gomock mode: source
• gomock version: 1.6.0
• golang version: 1.17.2

[codyoss]

Thanks for the issue, I will take a look!

[elchead]

Bug still persists, but I used a workaround with a custom matcher

test.mock.EXPECT().DoSomething(AnyOfStrings([]string{"foo","bar})).Return(&Response{})


type AnyOfStrings ([]string)
func (m *AnyOfStrings) Matches(x interface{}) bool {
	for _, v := range *m {
		if v == x.(string) {
			return true
		}
	}
	return false
}

func (m *AnyOfStrings) String() string {
	return fmt.Sprintf("is one of %v", *m)
}

[KabudoWiseMan]

Any updates on the issue?

[nicolasassi]

FYI Same problem were