google: make SDKConfig work with newer versions of gcloud #301

ojarjur · 2018-07-02T22:00:17Z

The existing implementation of SDKConfig assumes that the Cloud SDK
writes a config file named "credentials", which contains JSON-encoded
OAuth2 credentials for the user.

Since version 161.0.0 of the Cloud SDK, that has not been true, as the
Cloud SDK has switched to storing credentials in a SQLite database
instead of a JSON-encoded file.

This change switches from trying to directly read the underlying
credential store (which it is now clear can change without notice), to
instead invoking the "gcloud" command and asking it for its
credentials. This is done using the subcommand "gcloud config config-helper"

That subcommand is meant to provide auth data to external tools, so it
seems to be a more appropriate choice than reading the underlying
storage directly.

Fixes #300

The existing implementation of SDKConfig assumes that the Cloud SDK writes a config file named `credentials`, which contains JSON-encoded OAuth2 credentials for the user. Since version 161.0.0 of the Cloud SDK, that has not been true, as the Cloud SDK has switched to storing credentials in a SQLite database instead of a JSON-encoded file. This change switches from trying to directly read the underlying credential store (which it is now clear can change without notice), to instead invoking the `gcloud` command and asking it for its credentials. This is done using the subcommand ```sh gcloud config config-helper ``` That subcommand is meant to provide auth data to external tools, so it seems to be a more appropriate choice than reading the underlying storage directly. This fixes golang#300

gopherbot · 2018-07-02T22:16:00Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-12-18T22:20:11Z

This PR (HEAD: bf936a0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/121939 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-12-20T20:59:38Z

Message from Bryan C. Mills:

Patch Set 2:

(5 comments)

Thanks for the contribution!

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

This change makes the error messages generated by the sdk component consistent both in terms of contents and in terms of when returned errors are wrapped.

gopherbot · 2018-12-20T21:44:55Z

This PR (HEAD: ebcc2cd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/121939 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-12-20T22:05:45Z

Message from Omar Jarjur:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-11T16:53:35Z

Message from Brad Fitzpatrick:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-11T16:54:13Z

Message from Brad Fitzpatrick:

Patch Set 5: Patch Set 4 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-11T16:54:15Z

Message from Brad Fitzpatrick:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-11T16:54:16Z

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e26f11d7

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-11T16:55:33Z

Message from Gobot Gobot:

Patch Set 5:

Build is still in progress...
This change failed on windows-amd64-2016:
See https://storage.googleapis.com/go-build-log/a2bb68de/windows-amd64-2016_aab653ea.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-11T16:59:54Z

Message from Gobot Gobot:

Patch Set 5: TryBot-Result-1

2 of 17 TryBots failed:
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/a2bb68de/windows-amd64-2016_aab653ea.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/a2bb68de/windows-386-2008_b2da18bc.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

…DKConfig.Token() method

gopherbot · 2019-01-11T22:23:29Z

This PR (HEAD: 1ebe5b9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/121939 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-01-11T23:56:14Z

Message from Brad Fitzpatrick:

Patch Set 6: Run-TryBot+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-11T23:56:43Z

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=c88e296b

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-12T00:09:56Z

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-12T01:27:09Z

This PR (HEAD: a160a16) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/121939 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-01-12T01:29:45Z

Message from Omar Jarjur:

Patch Set 7:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-14T19:42:24Z

Message from Brad Fitzpatrick:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-01-14T19:51:42Z

Message from Omar Jarjur:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:53:22Z

Message from Go Bot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e26f11d7

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:53:23Z

Message from Go Bot:

Patch Set 5:

Build is still in progress...
This change failed on windows-amd64-2016:
See https://storage.googleapis.com/go-build-log/a2bb68de/windows-amd64-2016_aab653ea.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:53:24Z

Message from Go Bot:

Patch Set 5: TryBot-Result-1

2 of 17 TryBots failed:
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/a2bb68de/windows-amd64-2016_aab653ea.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/a2bb68de/windows-386-2008_b2da18bc.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:53:25Z

Message from Go Bot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=c88e296b

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:53:26Z

Message from Go Bot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:05Z

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:06Z

Message from Bryan C. Mills:

Patch Set 2:

(5 comments)

Thanks for the contribution!

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:07Z

Message from Omar Jarjur:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:09Z

Message from Brad Fitzpatrick:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:10Z

Message from Brad Fitzpatrick:

Patch Set 5: Patch Set 4 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:11Z

Message from Brad Fitzpatrick:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:11Z

Message from Go Bot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=e26f11d7

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:12Z

Message from Go Bot:

Patch Set 5:

Build is still in progress...
This change failed on windows-amd64-2016:
See https://storage.googleapis.com/go-build-log/a2bb68de/windows-amd64-2016_aab653ea.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:13Z

Message from Go Bot:

Patch Set 5: TryBot-Result-1

2 of 17 TryBots failed:
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/a2bb68de/windows-amd64-2016_aab653ea.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/a2bb68de/windows-386-2008_b2da18bc.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:14Z

Message from Brad Fitzpatrick:

Patch Set 6: Run-TryBot+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:15Z

Message from Go Bot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=c88e296b

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:16Z

Message from Go Bot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:16Z

Message from Omar Jarjur:

Patch Set 7:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:17Z

Message from Brad Fitzpatrick:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:18Z

Message from Omar Jarjur:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/121939.
After addressing review feedback, remember to publish your drafts!

googlebot added the cla: yes label Jul 2, 2018

rohansingh mentioned this pull request Dec 18, 2018

SDKConfig doesn't work past gcloud v179.0.0 #300

Open

Merge branch 'master' into master

bf936a0

ojarjur changed the title ~~make SDKConfig work with newer versions of gcloud~~ google: make SDKConfig work with newer versions of gcloud Dec 20, 2018

google: make the sdk error messages consistent

ebcc2cd

This change makes the error messages generated by the sdk component consistent both in terms of contents and in terms of when returned errors are wrapped.

ojarjur added 2 commits January 11, 2019 13:20

Merge branch 'master' of https://go.googlesource.com/oauth2

42c170e

Inline the logic for fetching a token from gcloud directly into the S…

1ebe5b9

…DKConfig.Token() method

Simplify and shorten the code for the SDKConfig TokenSource

a160a16

google: make SDKConfig work with newer versions of gcloud #301

Are you sure you want to change the base?

google: make SDKConfig work with newer versions of gcloud #301

Conversation

ojarjur commented Jul 2, 2018 • edited Loading

gopherbot commented Jul 2, 2018

gopherbot commented Dec 18, 2018

gopherbot commented Dec 20, 2018

gopherbot commented Dec 20, 2018

gopherbot commented Dec 20, 2018

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 11, 2019

gopherbot commented Jan 12, 2019

gopherbot commented Jan 12, 2019

gopherbot commented Jan 12, 2019

gopherbot commented Jan 14, 2019

gopherbot commented Jan 14, 2019

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

gopherbot commented Nov 8, 2021

ojarjur commented Jul 2, 2018 •

edited

Loading