-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for option to bypass query escaping the auth header credentials #351
Conversation
Some OAuth2 providers don’t correctly decode the URL escaped auth header
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLA signed. |
CLAs look good, thanks! |
This PR (HEAD: 9a6b29a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/153878 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/153878. |
Message from Brad Fitzpatrick: Patch Set 1: I would really rather not add more sad knobs like this to compensate for broken servers. The existing one is sad enough. Can we instead just try both ways? If one fails, try the other? Please don’t reply on this GitHub thread. Visit golang.org/cl/153878. |
Message from Matt Wielbut: Patch Set 1:
I'm ok with that approach. An extra 401 shouldn't be that bad. Please don’t reply on this GitHub thread. Visit golang.org/cl/153878. |
any plans on merging this PR ? |
any plans for releasing this change? |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/153878. |
Will this PR ever be merged? |
Closing in favor of #476 |
Some (many, it seems) OAuth providers do not adhere to the standard of accepting query escaped credentials. If your client ID or client secret contains non-URL query characters they will be rejected by the OAuth provider.
The current implementation always query escapes the
client_id
andclient_secret
:req.SetBasicAuth(url.QueryEscape(clientID), url.QueryEscape(clientSecret))
This PR proposes the ability the register an auth provider that does not escape the header and bypasses the escaping.
func RegisterNonQueryEscapedAuthHeaderProvider(tokenURL string)
and
This has been raised several times:
#251
#318
#320
but without this feature this library cannot be used against some key OAuth providers.
We already have the ability to bypass the header authentication for OAuth providers that require a
client_id
andclient_secret
be passed as parameters--this builds on that.