all: merge master (b5a64bb) into gopls-release-branch.0.18

Also add back the replace directive.

For golang/go#71607

Conflicts:

- gopls/go.mod
- gopls/go.sum

Merge List:

+ 2025-02-12 b5a64bb go/analysis/internal/checker: be silent with -fix
+ 2025-02-11 b752317 internal/analysisinternal: disable AddImport test without go command
+ 2025-02-11 d98774e cmd/signature-fuzzer/internal/fuzz-generator: update to math/rand/v2
+ 2025-02-11 2593262 gopls/internal/telemetry/cmd/stacks: remove leading \b match
+ 2025-02-11 b3c5d10 gopls: record telemetry counters for settings that are used
+ 2025-02-11 d2585c4 gopls/internal/golang: folding range: remove FoldingRangeInfo
+ 2025-02-11 0d16805 internal/stdlib: update stdlib index for Go 1.24.0
+ 2025-02-11 027eab5 go/analysis/analysistest: RunWithSuggestedFix: 3-way merge
+ 2025-02-10 f61b225 internal/analysisinternal: AddImport puts new import in a group
+ 2025-02-10 91bac86 internal/analysisinternal: add CanImport
+ 2025-02-10 94c41d3 gopls/internal/golang: add comment about SymbolKind
+ 2025-02-10 09747cd go.mod: update golang.org/x dependencies
+ 2025-02-10 dc9353b gopls/internal/analysis/modernize: appendclipped: unclip
+ 2025-02-07 a886a1c internal/analysisinternal: AddImport handles dot imports
+ 2025-02-07 94c3c49 go/analysis/analysistest: RunWithSuggestedFix: assume valid fixes
+ 2025-02-07 5f9967d gopls/internal/analysis/modernize: strings.Split -> SplitSeq
+ 2025-02-07 a1eb5fd go/analysis/passes/framepointer: support arm64
+ 2025-02-07 9c087d9 internal/analysis/gofix: change "forward" back to "inline"
+ 2025-02-07 82317ce gopls/internal/analysis/modernize: slices.Delete: import slices

Change-Id: I5e21f982437cd4288f71b00484fa589ddcab8df6

Author: findleyr

cmd/signature-fuzzer/internal/fuzz-generator/wraprand.go

@@ -6,7 +6,7 @@ package generator
 
 import (
 	"fmt"
-	"math/rand"
+	"math/rand/v2"
 	"os"
 	"runtime"
 	"strings"
@@ -20,8 +20,7 @@ const (
 )
 
 func NewWrapRand(seed int64, ctl int) *wraprand {
-	rand.Seed(seed)
-	return &wraprand{seed: seed, ctl: ctl}
+	return &wraprand{seed: seed, ctl: ctl, rand: rand.New(rand.NewPCG(0, uint64(seed)))}
 }
 
 type wraprand struct {
@@ -32,6 +31,7 @@ type wraprand struct {
 	tag       string
 	calls     []string
 	ctl       int
+	rand      *rand.Rand
 }
 
 func (w *wraprand) captureCall(tag string, val string) {
@@ -59,7 +59,7 @@ func (w *wraprand) captureCall(tag string, val string) {
 
 func (w *wraprand) Intn(n int64) int64 {
 	w.intncalls++
-	rv := rand.Int63n(n)
+	rv := w.rand.Int64N(n)
 	if w.ctl&RandCtlCapture != 0 {
 		w.captureCall("Intn", fmt.Sprintf("%d", rv))
 	}
@@ -68,7 +68,7 @@ func (w *wraprand) Intn(n int64) int64 {
 
 func (w *wraprand) Float32() float32 {
 	w.f32calls++
-	rv := rand.Float32()
+	rv := w.rand.Float32()
 	if w.ctl&RandCtlCapture != 0 {
 		w.captureCall("Float32", fmt.Sprintf("%f", rv))
 	}
@@ -77,15 +77,15 @@ func (w *wraprand) Float32() float32 {
 
 func (w *wraprand) NormFloat64() float64 {
 	w.f64calls++
-	rv := rand.NormFloat64()
+	rv := w.rand.NormFloat64()
 	if w.ctl&RandCtlCapture != 0 {
 		w.captureCall("NormFloat64", fmt.Sprintf("%f", rv))
 	}
 	return rv
 }
 
 func (w *wraprand) emitCalls(fn string) {
-	outf, err := os.OpenFile(fn, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0666)
+	outf, err := os.OpenFile(fn, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0o666)
 	if err != nil {
 		panic(err)
 	}

go.mod

@@ -5,10 +5,10 @@ go 1.22.0 // => default GODEBUG has gotypesalias=0
 require (
 	github.com/google/go-cmp v0.6.0
 	github.com/yuin/goldmark v1.4.13
-	golang.org/x/mod v0.22.0
-	golang.org/x/net v0.34.0
-	golang.org/x/sync v0.10.0
+	golang.org/x/mod v0.23.0
+	golang.org/x/net v0.35.0
+	golang.org/x/sync v0.11.0
 	golang.org/x/telemetry v0.0.0-20240521205824-bda55230c457
 )
 
-require golang.org/x/sys v0.29.0 // indirect
+require golang.org/x/sys v0.30.0 // indirect

go.sum

@@ -2,13 +2,13 @@ github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/yuin/goldmark v1.4.13 h1:fVcFKWvrslecOb/tg+Cc05dkeYx540o0FuFt3nUVDoE=
 github.com/yuin/goldmark v1.4.13/go.mod h1:6yULJ656Px+3vBD8DxQVa3kxgyrAnzto9xy5taEt/CY=
-golang.org/x/mod v0.22.0 h1:D4nJWe9zXqHOmWqj4VMOJhvzj7bEZg4wEYa759z1pH4=
-golang.org/x/mod v0.22.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
-golang.org/x/net v0.34.0 h1:Mb7Mrk043xzHgnRM88suvJFwzVrRfHEHJEl5/71CKw0=
-golang.org/x/net v0.34.0/go.mod h1:di0qlW3YNM5oh6GqDGQr92MyTozJPmybPK4Ev/Gm31k=
-golang.org/x/sync v0.10.0 h1:3NQrjDixjgGwUOCaF8w2+VYHv0Ve/vGYSbdkTa98gmQ=
-golang.org/x/sync v0.10.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
-golang.org/x/sys v0.29.0 h1:TPYlXGxvx1MGTn2GiZDhnjPA9wZzZeGKHHmKhHYvgaU=
-golang.org/x/sys v0.29.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
+golang.org/x/mod v0.23.0 h1:Zb7khfcRGKk+kqfxFaP5tZqCnDZMjC5VtUBs87Hr6QM=
+golang.org/x/mod v0.23.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
+golang.org/x/net v0.35.0 h1:T5GQRQb2y08kTAByq9L4/bz8cipCdA8FbRTXewonqY8=
+golang.org/x/net v0.35.0/go.mod h1:EglIi67kWsHKlRzzVMUD93VMSWGFOMSZgxFjparz1Qk=
+golang.org/x/sync v0.11.0 h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=
+golang.org/x/sync v0.11.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
+golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
+golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/telemetry v0.0.0-20240521205824-bda55230c457 h1:zf5N6UOrA487eEFacMePxjXAJctxKmyjKUsjA11Uzuk=
 golang.org/x/telemetry v0.0.0-20240521205824-bda55230c457/go.mod h1:pRgIJT+bRLFKnoM1ldnzKoxTIn14Yxz928LQRYYgIN0=