Skip to content

Commit 30439fc

Browse files
committed
all: merge master (e65ea15) into gopls-release-branch.0.18
Also add back the x/tools replace directive. For golang/go#71607 Merge List: + 2025-02-07 e65ea15 go/analysis/internal/checker: implement three-way merge + 2025-02-07 a9bf6fd gopls/internal/analysis/modernize: remove SortStable + 2025-02-07 4d1de70 internal/apidiff: remove Change-Id: I85447333201cddcc9f0aa8ba711af28abdc877c7
2 parents 1fbbb64 + e65ea15 commit 30439fc

File tree

25 files changed

+985
-3236
lines changed

25 files changed

+985
-3236
lines changed

go/analysis/analysistest/analysistest.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@ import (
3636
// and populates it with a GOPATH-style project using filemap (which
3737
// maps file names to contents). On success it returns the name of the
3838
// directory and a cleanup function to delete it.
39+
//
40+
// TODO(adonovan): provide a newer version that accepts a testing.T,
41+
// calls T.TempDir, and calls T.Fatal on any error, avoiding the need
42+
// to return cleanup or err:
43+
//
44+
// func WriteFilesToTmp(t *testing.T filemap map[string]string) string
3945
func WriteFiles(filemap map[string]string) (dir string, cleanup func(), err error) {
4046
gopath, err := os.MkdirTemp("", "analysistest")
4147
if err != nil {

0 commit comments

Comments
 (0)