Skip to content

Commit 1052555

Browse files
build(deps): bump github.com/mgechev/revive from 1.9.0 to 1.10.0 (#5837)
Co-authored-by: Fernandez Ludovic <[email protected]>
1 parent b9510d7 commit 1052555

File tree

5 files changed

+78
-65
lines changed

5 files changed

+78
-65
lines changed

.golangci.next.reference.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2589,7 +2589,7 @@ linters:
25892589
severity: warning
25902590
disabled: false
25912591
exclude: [""]
2592-
# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#redundant-test-main-exit
2592+
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#redundant-test-main-exit
25932593
- name: redundant-test-main-exit
25942594
severity: warning
25952595
disabled: false
@@ -2629,6 +2629,11 @@ linters:
26292629
exclude: [""]
26302630
arguments:
26312631
- "preserve-scope"
2632+
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#time-date
2633+
- name: time-date
2634+
severity: warning
2635+
disabled: false
2636+
exclude: [""]
26322637
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#time-equal
26332638
- name: time-equal
26342639
severity: warning
@@ -2669,6 +2674,11 @@ linters:
26692674
arguments:
26702675
- "fmt.Printf"
26712676
- "myFunction"
2677+
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#unnecessary-format
2678+
- name: unnecessary-format
2679+
severity: warning
2680+
disabled: false
2681+
exclude: [""]
26722682
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#unnecessary-stmt
26732683
- name: unnecessary-stmt
26742684
severity: warning
@@ -2703,6 +2713,11 @@ linters:
27032713
severity: warning
27042714
disabled: false
27052715
exclude: [""]
2716+
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#use-fmt-print
2717+
- name: use-fmt-print
2718+
severity: warning
2719+
disabled: false
2720+
exclude: [""]
27062721
# https://github.com/mgechev/revive/blob/HEAD/RULES_DESCRIPTIONS.md#useless-break
27072722
- name: useless-break
27082723
severity: warning

go.mod

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ require (
8080
github.com/maratori/testpackage v1.1.1
8181
github.com/matoous/godox v1.1.0
8282
github.com/mattn/go-colorable v0.1.14
83-
github.com/mgechev/revive v1.9.0
83+
github.com/mgechev/revive v1.10.0
8484
github.com/mitchellh/go-homedir v1.1.0
8585
github.com/moricho/tparallel v0.3.2
8686
github.com/nakabonne/nestif v0.3.1
@@ -141,6 +141,7 @@ require (
141141
)
142142

143143
require (
144+
codeberg.org/chavacava/garif v0.2.0 // indirect
144145
github.com/Masterminds/semver/v3 v3.3.1 // indirect
145146
github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
146147
github.com/beorn7/perks v1.0.1 // indirect
@@ -150,7 +151,6 @@ require (
150151
github.com/charmbracelet/x/ansi v0.8.0 // indirect
151152
github.com/charmbracelet/x/cellbuf v0.0.13-0.20250311204145-2c3ea96c31dd // indirect
152153
github.com/charmbracelet/x/term v0.2.1 // indirect
153-
github.com/chavacava/garif v0.1.0 // indirect
154154
github.com/dave/dst v0.27.3 // indirect
155155
github.com/davecgh/go-spew v1.1.1 // indirect
156156
github.com/dlclark/regexp2 v1.11.5 // indirect
@@ -184,7 +184,6 @@ require (
184184
github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
185185
github.com/mitchellh/mapstructure v1.5.0 // indirect
186186
github.com/muesli/termenv v0.16.0 // indirect
187-
github.com/olekukonko/tablewriter v0.0.5 // indirect
188187
github.com/pelletier/go-toml v1.9.5 // indirect
189188
github.com/pmezard/go-difflib v1.0.0 // indirect
190189
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect

go.sum

Lines changed: 4 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jsonschema/golangci.next.jsonschema.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -638,19 +638,22 @@
638638
"string-of-int",
639639
"struct-tag",
640640
"superfluous-else",
641+
"time-date",
641642
"time-equal",
642643
"time-naming",
643644
"unchecked-type-assertion",
644645
"unconditional-recursion",
645646
"unexported-naming",
646647
"unexported-return",
647648
"unhandled-error",
649+
"unnecessary-format",
648650
"unnecessary-stmt",
649651
"unreachable-code",
650652
"unused-parameter",
651653
"unused-receiver",
652654
"use-any",
653655
"use-errors-new",
656+
"use-fmt-print",
654657
"useless-break",
655658
"var-declaration",
656659
"var-naming",

pkg/golinters/revive/revive.go

Lines changed: 53 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ func (w *wrapper) toIssue(pass *analysis.Pass, failure *lint.Failure) goanalysis
152152
f := pass.Fset.File(token.Pos(failure.Position.Start.Offset))
153153

154154
// Skip cgo files because the positions are wrong.
155-
if failure.GetFilename() == f.Name() {
155+
if failure.Filename() == f.Name() {
156156
issue.SuggestedFixes = []analysis.SuggestedFix{{
157157
TextEdits: []analysis.TextEdit{{
158158
Pos: f.LineStart(failure.Position.Start.Line),
@@ -269,7 +269,7 @@ func safeTomlSlice(r []any) []any {
269269
}
270270

271271
// This element is not exported by revive, so we need copy the code.
272-
// Extracted from https://github.com/mgechev/revive/blob/v1.6.0/config/config.go#L16
272+
// Extracted from https://github.com/mgechev/revive/blob/v1.10.0/config/config.go#L16
273273
var defaultRules = []lint.Rule{
274274
&rule.VarDeclarationsRule{},
275275
&rule.PackageCommentsRule{},
@@ -297,66 +297,70 @@ var defaultRules = []lint.Rule{
297297
}
298298

299299
var allRules = append([]lint.Rule{
300+
&rule.AddConstantRule{},
300301
&rule.ArgumentsLimitRule{},
301-
&rule.CyclomaticRule{},
302-
&rule.FileHeaderRule{},
302+
&rule.AtomicRule{},
303+
&rule.BannedCharsRule{},
304+
&rule.BareReturnRule{},
305+
&rule.BoolLiteralRule{},
306+
&rule.CallToGCRule{},
307+
&rule.CognitiveComplexityRule{},
308+
&rule.CommentsDensityRule{},
309+
&rule.CommentSpacingsRule{},
303310
&rule.ConfusingNamingRule{},
304-
&rule.GetReturnRule{},
305-
&rule.ModifiesParamRule{},
306311
&rule.ConfusingResultsRule{},
307-
&rule.DeepExitRule{},
308-
&rule.AddConstantRule{},
309-
&rule.FlagParamRule{},
310-
&rule.UnnecessaryStmtRule{},
311-
&rule.StructTagRule{},
312-
&rule.ModifiesValRecRule{},
313312
&rule.ConstantLogicalExprRule{},
314-
&rule.BoolLiteralRule{},
315-
&rule.ImportsBlocklistRule{},
316-
&rule.FunctionResultsLimitRule{},
317-
&rule.MaxPublicStructsRule{},
318-
&rule.RangeValInClosureRule{},
319-
&rule.RangeValAddress{},
320-
&rule.WaitGroupByValueRule{},
321-
&rule.AtomicRule{},
322-
&rule.EmptyLinesRule{},
323-
&rule.LineLengthLimitRule{},
324-
&rule.CallToGCRule{},
313+
&rule.CyclomaticRule{},
314+
&rule.DataRaceRule{},
315+
&rule.DeepExitRule{},
316+
&rule.DeferRule{},
325317
&rule.DuplicatedImportsRule{},
326-
&rule.ImportShadowingRule{},
327-
&rule.BareReturnRule{},
328-
&rule.UnusedReceiverRule{},
329-
&rule.UnhandledErrorRule{},
330-
&rule.CognitiveComplexityRule{},
331-
&rule.StringOfIntRule{},
332-
&rule.StringFormatRule{},
333318
&rule.EarlyReturnRule{},
334-
&rule.UnconditionalRecursionRule{},
335-
&rule.IdenticalBranchesRule{},
336-
&rule.DeferRule{},
337-
&rule.UnexportedNamingRule{},
338-
&rule.FunctionLength{},
339-
&rule.NestedStructs{},
340-
&rule.UselessBreak{},
341-
&rule.UncheckedTypeAssertionRule{},
342-
&rule.TimeEqualRule{},
343-
&rule.BannedCharsRule{},
344-
&rule.OptimizeOperandsOrderRule{},
345-
&rule.UseAnyRule{},
346-
&rule.DataRaceRule{},
347-
&rule.CommentSpacingsRule{},
348-
&rule.IfReturnRule{},
349-
&rule.RedundantImportAlias{},
350-
&rule.ImportAliasNamingRule{},
319+
&rule.EmptyLinesRule{},
351320
&rule.EnforceMapStyleRule{},
352321
&rule.EnforceRepeatedArgTypeStyleRule{},
353322
&rule.EnforceSliceStyleRule{},
354-
&rule.MaxControlNestingRule{},
355-
&rule.CommentsDensityRule{},
323+
&rule.FileHeaderRule{},
356324
&rule.FileLengthLimitRule{},
357325
&rule.FilenameFormatRule{},
326+
&rule.FlagParamRule{},
327+
&rule.FunctionLength{},
328+
&rule.FunctionResultsLimitRule{},
329+
&rule.GetReturnRule{},
330+
&rule.IdenticalBranchesRule{},
331+
&rule.IfReturnRule{},
332+
&rule.ImportAliasNamingRule{},
333+
&rule.ImportsBlocklistRule{},
334+
&rule.ImportShadowingRule{},
335+
&rule.LineLengthLimitRule{},
336+
&rule.MaxControlNestingRule{},
337+
&rule.MaxPublicStructsRule{},
338+
&rule.ModifiesParamRule{},
339+
&rule.ModifiesValRecRule{},
340+
&rule.NestedStructs{},
341+
&rule.OptimizeOperandsOrderRule{},
342+
&rule.RangeValAddress{},
343+
&rule.RangeValInClosureRule{},
358344
&rule.RedundantBuildTagRule{},
345+
&rule.RedundantImportAlias{},
346+
&rule.RedundantTestMainExitRule{},
347+
&rule.StringFormatRule{},
348+
&rule.StringOfIntRule{},
349+
&rule.StructTagRule{},
350+
&rule.TimeDateRule{},
351+
&rule.TimeEqualRule{},
352+
&rule.UncheckedTypeAssertionRule{},
353+
&rule.UnconditionalRecursionRule{},
354+
&rule.UnexportedNamingRule{},
355+
&rule.UnhandledErrorRule{},
356+
&rule.UnnecessaryFormatRule{},
357+
&rule.UnnecessaryStmtRule{},
358+
&rule.UnusedReceiverRule{},
359+
&rule.UseAnyRule{},
359360
&rule.UseErrorsNewRule{},
361+
&rule.UseFmtPrintRule{},
362+
&rule.UselessBreak{},
363+
&rule.WaitGroupByValueRule{},
360364
}, defaultRules...)
361365

362366
const defaultConfidence = 0.8

0 commit comments

Comments
 (0)