Skip to content

docs: too many E(inv=2, role=user) plus reformatting #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −7
Open

docs: too many E(inv=2, role=user) plus reformatting #3538

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef6ac33
Too many E(inv=2, role=user) plus reformatting
adrianad Nov 13, 2025
8abcf19
Merge branch 'main' into patch-1
hangfei Nov 13, 2025
627b933
Apply suggestions from code review
adrianad Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/google/adk/apps/compaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,10 @@ async def _run_compaction_for_sliding_window(
beginning.
- A `CompactedEvent` is generated, summarizing events within
`invocation_id` range [1, 2].
- The session now contains: `[E(inv=1, role=user), E(inv=1, role=model),
E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user),
CompactedEvent(inv=[1, 2])]`.
- The session now contains: `[
E(inv=1, role=user), E(inv=1, role=model),
E(inv=2, role=user), E(inv=2, role=model),
CompactedEvent(inv=[1, 2])]`.

2. **After `invocation_id` 3 events are added:**
- No compaction happens yet, because only 1 new invocation (`inv=3`)
Expand All @@ -91,10 +92,13 @@ async def _run_compaction_for_sliding_window(
- The new compaction range is from `invocation_id` 2 to 4.
- A new `CompactedEvent` is generated, summarizing events within
`invocation_id` range [2, 4].
- The session now contains: `[E(inv=1, role=user), E(inv=1, role=model),
E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user),
CompactedEvent(inv=[1, 2]), E(inv=3, role=user), E(inv=3, role=model),
E(inv=4, role=user), E(inv=4, role=model), CompactedEvent(inv=[2, 4])]`.
- The session now contains: `[
E(inv=1, role=user), E(inv=1, role=model),
E(inv=2, role=user), E(inv=2, role=model),
CompactedEvent(inv=[1, 2]),
E(inv=3, role=user), E(inv=3, role=model),
E(inv=4, role=user), E(inv=4, role=model),
CompactedEvent(inv=[2, 4])]`.


Args:
Expand Down