Can't compile with gcc 14.2 due to nothings/stb#1642

[footballhead]

[98/421] Building CXX object src/CMakeFiles/ppx.dir/ppx/bitmap.cpp.o
FAILED: src/CMakeFiles/ppx.dir/ppx/bitmap.cpp.o 
/usr/bin/c++ -DGLFW_INCLUDE_NONE -DPPX_LINUX -DPPX_LINUX_XCB -DPPX_VULKAN -DRELATIVE_PATH_TO_PROJECT_ROOT=\"..\" -DSTACK_LINE_READER_BUFFER_SIZE=1024 -I/usr/local/google/home/hitchens/git/bigwheels/src -I/usr/local/google/home/hitchens/git/bigwheels/include -I/usr/local/google/home/hitchens/git/bigwheels/third_party/glfw/include -I/usr/local/google/home/hitchens/git/bigwheels/third_party/glm -I/usr/local/google/home/hitchens/git/bigwheels/third_party/gli -I/usr/local/google/home/hitchens/git/bigwheels/third_party/stb -I/usr/local/google/home/hitchens/git/bigwheels/third_party/imgui -I/usr/local/google/home/hitchens/git/bigwheels/third_party/tinyobjloader -I/usr/local/google/home/hitchens/git/bigwheels/third_party/pcg32 -I/usr/local/google/home/hitchens/git/bigwheels/third_party/cgltf -I/usr/local/google/home/hitchens/git/bigwheels/third_party/xxHash -I/usr/local/google/home/hitchens/git/bigwheels/third_party/utfcpp/source -I/usr/local/google/home/hitchens/git/bigwheels/third_party/json/single_include -I/usr/local/google/home/hitchens/git/bigwheels/third_party/VulkanMemoryAllocator/include -I/usr/local/google/home/hitchens/git/bigwheels/third_party/VulkanMemoryAllocator/src -I/usr/local/google/home/hitchens/vulkan_sdk/1.3.275.0/x86_64/include -I/usr/local/google/home/hitchens/git/bigwheels/third_party/cpu_features/include -Werror         -std=c++17         -fdiagnostics-color=always         -Wno-nullability-completeness         -Wno-deprecated-anon-enum-enum-conversion         -Wno-missing-field-initializers         -Wno-unused-parameter         -Wno-ignored-qualifiers         -Wno-deprecated-copy         -Wno-deprecated-enum-enum-conversion         -Wno-pointer-bool-conversion      -O3 -DNDEBUG -std=gnu++17 -MD -MT src/CMakeFiles/ppx.dir/ppx/bitmap.cpp.o -MF src/CMakeFiles/ppx.dir/ppx/bitmap.cpp.o.d -o src/CMakeFiles/ppx.dir/ppx/bitmap.cpp.o -c /usr/local/google/home/hitchens/git/bigwheels/src/ppx/bitmap.cpp
In file included from /usr/local/google/home/hitchens/git/bigwheels/src/ppx/bitmap.cpp:18:
/usr/local/google/home/hitchens/git/bigwheels/third_party/stb/stb_image.h: In function ‘int stbi__parse_png_file(stbi__png*, int, int)’:
/usr/local/google/home/hitchens/git/bigwheels/third_party/stb/stb_image.h:5109:56: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
 5109 |                   for (k = 0; k < s->img_n; ++k) tc[k] = (stbi_uc)(stbi__get16be(s) & 255) * stbi__depth_scale_table[z->depth]; // non 8-bit images will be larger
      |                                                  ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/google/home/hitchens/git/bigwheels/third_party/stb/stb_image.h:5026:25: note: at offset 3 into destination object ‘tc’ of size 3
 5026 |    stbi_uc has_trans=0, tc[3]={0};
      |                         ^~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-pointer-bool-conversion’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-deprecated-anon-enum-enum-conversion’ may have been intended to silence earlier diagnostics
cc1plus: note: unrecognized command-line option ‘-Wno-nullability-completeness’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors

Works fine with clang

[footballhead]

In a pinch, a workaround is to disable the warning:

target_compile_options( 
    ${PROJECT_NAME} 
    PRIVATE -Wno-unused-result
)

This hasn't been checked in since we should strive to fix the underlying issue.

[footballhead]

Oddly, I don't hit this if I use -DCMAKE_BUILD_TYPE=Debug. It only happens on Release or if unset