Skip to content

Commit 741e5d0

Browse files
l46kokcopybara-github
authored andcommitted
Remove redundant FunctionBindingCreator interface, consolidate with CelStandardOverload
PiperOrigin-RevId: 826652181
1 parent cd05924 commit 741e5d0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+369
-404
lines changed

runtime/src/main/java/dev/cel/runtime/CelStandardFunctions.java

Lines changed: 212 additions & 241 deletions
Large diffs are not rendered by default.

runtime/src/main/java/dev/cel/runtime/standard/AddOperator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,16 +156,16 @@ public enum AddOverload implements CelStandardOverload {
156156
(celOptions, runtimeEquality) ->
157157
CelFunctionBinding.from("add_list", List.class, List.class, RuntimeHelpers::concat));
158158

159-
private final FunctionBindingCreator bindingCreator;
159+
private final CelStandardOverload standardOverload;
160160

161161
@Override
162162
public CelFunctionBinding newFunctionBinding(
163163
CelOptions celOptions, RuntimeEquality runtimeEquality) {
164-
return bindingCreator.create(celOptions, runtimeEquality);
164+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
165165
}
166166

167-
AddOverload(FunctionBindingCreator bindingCreator) {
168-
this.bindingCreator = bindingCreator;
167+
AddOverload(CelStandardOverload standardOverload) {
168+
this.standardOverload = standardOverload;
169169
}
170170
}
171171

runtime/src/main/java/dev/cel/runtime/standard/BoolFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,17 @@ public enum BoolOverload implements CelStandardOverload {
7272
}
7373
}));
7474

75-
private final FunctionBindingCreator bindingCreator;
75+
private final CelStandardOverload standardOverload;
7676
;
7777

7878
@Override
7979
public CelFunctionBinding newFunctionBinding(
8080
CelOptions celOptions, RuntimeEquality runtimeEquality) {
81-
return bindingCreator.create(celOptions, runtimeEquality);
81+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
8282
}
8383

84-
BoolOverload(FunctionBindingCreator bindingCreator) {
85-
this.bindingCreator = bindingCreator;
84+
BoolOverload(CelStandardOverload standardOverload) {
85+
this.standardOverload = standardOverload;
8686
}
8787
}
8888

runtime/src/main/java/dev/cel/runtime/standard/BytesFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,17 @@ public enum BytesOverload implements CelStandardOverload {
6161
}),
6262
;
6363

64-
private final FunctionBindingCreator bindingCreator;
64+
private final CelStandardOverload standardOverload;
6565
;
6666

6767
@Override
6868
public CelFunctionBinding newFunctionBinding(
6969
CelOptions celOptions, RuntimeEquality runtimeEquality) {
70-
return bindingCreator.create(celOptions, runtimeEquality);
70+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
7171
}
7272

73-
BytesOverload(FunctionBindingCreator bindingCreator) {
74-
this.bindingCreator = bindingCreator;
73+
BytesOverload(CelStandardOverload standardOverload) {
74+
this.standardOverload = standardOverload;
7575
}
7676
}
7777

runtime/src/main/java/dev/cel/runtime/standard/CelStandardOverload.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,9 @@
2525
* overload.
2626
*/
2727
@Immutable
28+
@FunctionalInterface
2829
public interface CelStandardOverload {
2930

3031
/** Constructs a new {@link CelFunctionBinding} for this CEL standard overload. */
3132
CelFunctionBinding newFunctionBinding(CelOptions celOptions, RuntimeEquality runtimeEquality);
32-
33-
/** TODO: To be removed in the upcoming CL */
34-
@FunctionalInterface
35-
@Immutable
36-
interface FunctionBindingCreator {
37-
CelFunctionBinding create(CelOptions celOptions, RuntimeEquality runtimeEquality);
38-
}
3933
}

runtime/src/main/java/dev/cel/runtime/standard/ContainsFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,16 +44,16 @@ public enum ContainsOverload implements CelStandardOverload {
4444
"contains_string", String.class, String.class, String::contains)),
4545
;
4646

47-
private final FunctionBindingCreator bindingCreator;
47+
private final CelStandardOverload standardOverload;
4848

4949
@Override
5050
public CelFunctionBinding newFunctionBinding(
5151
CelOptions celOptions, RuntimeEquality runtimeEquality) {
52-
return bindingCreator.create(celOptions, runtimeEquality);
52+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
5353
}
5454

55-
ContainsOverload(FunctionBindingCreator bindingCreator) {
56-
this.bindingCreator = bindingCreator;
55+
ContainsOverload(CelStandardOverload standardOverload) {
56+
this.standardOverload = standardOverload;
5757
}
5858
}
5959

runtime/src/main/java/dev/cel/runtime/standard/DivideOperator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,16 +76,16 @@ public enum DivideOverload implements CelStandardOverload {
7676
(Long x, Long y) -> RuntimeHelpers.uint64Divide(x, y, celOptions));
7777
}
7878
});
79-
private final FunctionBindingCreator bindingCreator;
79+
private final CelStandardOverload standardOverload;
8080

8181
@Override
8282
public CelFunctionBinding newFunctionBinding(
8383
CelOptions celOptions, RuntimeEquality runtimeEquality) {
84-
return bindingCreator.create(celOptions, runtimeEquality);
84+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
8585
}
8686

87-
DivideOverload(FunctionBindingCreator bindingCreator) {
88-
this.bindingCreator = bindingCreator;
87+
DivideOverload(CelStandardOverload standardOverload) {
88+
this.standardOverload = standardOverload;
8989
}
9090
}
9191

runtime/src/main/java/dev/cel/runtime/standard/DoubleFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,16 @@ public enum DoubleOverload implements CelStandardOverload {
7373
}),
7474
;
7575

76-
private final FunctionBindingCreator bindingCreator;
76+
private final CelStandardOverload standardOverload;
7777

7878
@Override
7979
public CelFunctionBinding newFunctionBinding(
8080
CelOptions celOptions, RuntimeEquality runtimeEquality) {
81-
return bindingCreator.create(celOptions, runtimeEquality);
81+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
8282
}
8383

84-
DoubleOverload(FunctionBindingCreator bindingCreator) {
85-
this.bindingCreator = bindingCreator;
84+
DoubleOverload(CelStandardOverload standardOverload) {
85+
this.standardOverload = standardOverload;
8686
}
8787
}
8888

runtime/src/main/java/dev/cel/runtime/standard/DurationFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,16 @@ public enum DurationOverload implements CelStandardOverload {
7474
})),
7575
;
7676

77-
private final FunctionBindingCreator bindingCreator;
77+
private final CelStandardOverload standardOverload;
7878

7979
@Override
8080
public CelFunctionBinding newFunctionBinding(
8181
CelOptions celOptions, RuntimeEquality runtimeEquality) {
82-
return bindingCreator.create(celOptions, runtimeEquality);
82+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
8383
}
8484

85-
DurationOverload(FunctionBindingCreator bindingCreator) {
86-
this.bindingCreator = bindingCreator;
85+
DurationOverload(CelStandardOverload standardOverload) {
86+
this.standardOverload = standardOverload;
8787
}
8888
}
8989

runtime/src/main/java/dev/cel/runtime/standard/DynFunction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,16 @@ public enum DynOverload implements CelStandardOverload {
4343
(celOptions, runtimeEquality) ->
4444
CelFunctionBinding.from("to_dyn", Object.class, (Object arg) -> arg));
4545

46-
private final FunctionBindingCreator bindingCreator;
46+
private final CelStandardOverload standardOverload;
4747

4848
@Override
4949
public CelFunctionBinding newFunctionBinding(
5050
CelOptions celOptions, RuntimeEquality runtimeEquality) {
51-
return bindingCreator.create(celOptions, runtimeEquality);
51+
return standardOverload.newFunctionBinding(celOptions, runtimeEquality);
5252
}
5353

54-
DynOverload(FunctionBindingCreator bindingCreator) {
55-
this.bindingCreator = bindingCreator;
54+
DynOverload(CelStandardOverload standardOverload) {
55+
this.standardOverload = standardOverload;
5656
}
5757
}
5858

0 commit comments

Comments
 (0)