Put "too many type params" error in checkTypes diagnostic group & default it to warning

The "too many type params" error originally had its own group just for ease of rollout. It's been around for multiple years by now, though. This also cleans up some JSCompiler unit tests with existing violations.

If your project enables checkTypes but not tooManyTypeParams, this means you will start seeing errors on extra template types.

PiperOrigin-RevId: 766258413

Author: lauraharker

src/com/google/javascript/jscomp/RhinoErrorReporter.java

@@ -58,7 +58,7 @@ class RhinoErrorReporter {
       DiagnosticType.disabled("JSC_JSDOC_IMPORT_TYPE_WARNING", "{0}");
 
   static final DiagnosticType TOO_MANY_TEMPLATE_PARAMS =
-      DiagnosticType.disabled("JSC_TOO_MANY_TEMPLATE_PARAMS", "{0}");
+      DiagnosticType.warning("JSC_TOO_MANY_TEMPLATE_PARAMS", "{0}");
 
   // Special-cased errors, so that they can be configured via the
   // warnings API.

src/com/google/javascript/jscomp/TypeCheck.java

@@ -377,6 +377,7 @@ public final class TypeCheck implements NodeTraversal.Callback, CompilerPass {
           POSSIBLE_INEXISTENT_PROPERTY,
           PROPERTY_ASSIGNMENT_TO_READONLY_VALUE,
           RhinoErrorReporter.CYCLIC_INHERITANCE_ERROR,
+          RhinoErrorReporter.TOO_MANY_TEMPLATE_PARAMS,
           RhinoErrorReporter.TYPE_PARSE_ERROR,
           RhinoErrorReporter.UNRECOGNIZED_TYPE_ERROR,
           SAME_INTERFACE_MULTIPLE_IMPLEMENTS,

src/com/google/javascript/jscomp/testing/TestExternsBuilder.java

@@ -107,7 +107,7 @@ public static String getClosureExternsAsSource() {
           " */",
           "$jscomp.arrayFromIterable = function(iterable) {};",
           "/**",
-          " * @param {string|!Iterable<T>|!Iterator<T>|!Arguments<T>} iterable",
+          " * @param {string|!Iterable<T>|!Iterator<T>|!Arguments} iterable",
           " * @return {!Iterator<T>}",
           " * @template T",
           " */",

test/com/google/javascript/jscomp/CheckTemplateParamsTest.java

@@ -47,7 +47,7 @@ protected CompilerPass getProcessor(Compiler compiler) {
   @Override
   protected CompilerOptions getOptions() {
     CompilerOptions options = super.getOptions();
-    options.setWarningLevel(DiagnosticGroups.TOO_MANY_TYPE_PARAMS, CheckLevel.WARNING);
+    options.setWarningLevel(DiagnosticGroups.CHECK_TYPES, CheckLevel.WARNING);
     return options;
   }
 

test/com/google/javascript/jscomp/TypeCheckNoTranspileTest.java

@@ -26,13 +26,6 @@
 @RunWith(JUnit4.class)
 public final class TypeCheckNoTranspileTest extends TypeCheckTestCase {
 
-  @Override
-  protected CompilerOptions getDefaultOptions() {
-    CompilerOptions options = super.getDefaultOptions();
-    options.setWarningLevel(DiagnosticGroups.TOO_MANY_TYPE_PARAMS, CheckLevel.WARNING);
-    return options;
-  }
-
   @Test
   public void testCorrectSubtyping_ofRecursiveTemplateType() {
     newTest()

test/com/google/javascript/jscomp/TypedScopeCreatorTest.java

@@ -8149,10 +8149,14 @@ public void testReportBadTypeAnnotation_invalidEnumTemplateParametersAreParsed()
 
   @Test
   public void testReportBadTypeAnnotationInExtraTemplateParameter() {
-    testWarning(
-        "class C {} var /** !C<!MissingType> */ x;", RhinoErrorReporter.UNRECOGNIZED_TYPE_ERROR);
-    testWarning(
-        "var /** !Array<string, !MissingType> */ x;", RhinoErrorReporter.UNRECOGNIZED_TYPE_ERROR);
+    test(
+        srcs("class C {} var /** !C<!MissingType> */ x;"),
+        warning(RhinoErrorReporter.UNRECOGNIZED_TYPE_ERROR),
+        warning(RhinoErrorReporter.TOO_MANY_TEMPLATE_PARAMS));
+    test(
+        srcs("var /** !Array<string, !MissingType> */ x;"),
+        warning(RhinoErrorReporter.UNRECOGNIZED_TYPE_ERROR),
+        warning(RhinoErrorReporter.TOO_MANY_TEMPLATE_PARAMS));
   }
 
   @Test

test/com/google/javascript/jscomp/integration/ClosureIntegrationTest.java

@@ -18,7 +18,6 @@
 
 import static com.google.common.truth.Truth.assertThat;
 import static com.google.common.truth.Truth.assertWithMessage;
-import static com.google.javascript.jscomp.DiagnosticGroups.CHECK_TYPES;
 import static com.google.javascript.rhino.testing.NodeSubject.assertNode;
 
 import com.google.common.collect.ImmutableList;
@@ -419,9 +418,15 @@ public void testTypecheckNativeModulesDoesntCrash_givenTemplatizedTypedefOfUnion
           const /** null */ n = /** @type {!a.TypeDef<?>} */ (0);
           """
         },
+        null,
         // Just making sure that typechecking ran and didn't crash.  It would be reasonable
         // for there also to be other type errors in this code before the final null assignment.
-        CHECK_TYPES);
+        new DiagnosticGroup[] {
+          DiagnosticGroups.CHECK_TYPES,
+          DiagnosticGroups.CHECK_TYPES,
+          DiagnosticGroups.CHECK_TYPES,
+          DiagnosticGroups.CHECK_TYPES
+        });
   }
 
   @Test