Skip to content

Commit 6e86254

Browse files
GitHub actions separate web tests (#2963)
Separating the web-tests from building the tests makes it more easy to spot and override failing web-tests. This is still testing only the English translation. There are legitimate warnings coming out of the web-test infrastructure and should be blocking. But sometimes the tests fail and need to be overridden.
1 parent d3fea80 commit 6e86254

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

.github/workflows/build.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,20 +149,28 @@ jobs:
149149
MDBOOK_BOOK__LANGUAGE: ${{ matrix.language }}
150150
run: mdbook test
151151

152+
web-tests:
153+
runs-on: ubuntu-latest
154+
needs: build
155+
steps:
156+
- name: Checkout
157+
uses: actions/checkout@v5
152158
- name: Setup Node
153-
if: matrix.language == 'en'
154159
uses: actions/setup-node@v5
155160
with:
156161
node-version: 22
157162
cache: "npm"
158163
cache-dependency-path: "tests/package-lock.json"
159164
- name: Install test framework
160-
if: matrix.language == 'en'
161165
run: npm install
162166
working-directory: ./tests
167+
- name: Download english book
168+
uses: actions/download-artifact@v6
169+
with:
170+
name: comprehensive-rust-en
171+
path: book/
163172
- name: Test Javascript
164-
if: matrix.language == 'en'
165-
run: cargo xtask web-tests --dir book/comprehensive-rust-${{ matrix.language }}/html
173+
run: cargo xtask web-tests --dir book/comprehensive-rust-en/html
166174

167175
po-diff:
168176
name: Translation diff

0 commit comments

Comments
 (0)