Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-openapi: wrong type for google.protobuf.UInt64Value and StringValue #360

Closed
EladSisu opened this issue Jul 12, 2022 · 2 comments

Comments

@EladSisu
Copy link

EladSisu commented Jul 12, 2022

Both types: google.protobuf.UInt64Value & google.protobuf.StringValue not getting converted correctly to openapi and is missing descriptions.

for example this proto :

message Request {
// A limit on the number of objects to be returned, between 1 and 100.
google.protobuf.UInt64Value limit = 1

getting converted into:

  • name: limit.value
    in: query
    description: The uint64 value.
    schema:
    type: integer
    format: uint64

expected output :

  • name: limit
    description: A limit on the number of objects to be returned, between 1 and 100.
    in: query
    required: false
    schema:
    type: int64
    format: uint64
@galihputera
Copy link
Contributor

galihputera commented Sep 1, 2022

Hi maintainer team! We have a similar issue for protoc-gen-openapi. I already made an MR here #366. Need your review

@jeffsawatzky
Copy link
Contributor

@EladSisu / @galihputera now that #366 is merged, can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants