Reload not happening

[arnabanimesh]

What version of OR-Tools and what language are you using?
Version: v9.11
Language: Python

Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
Routing Solver

What operating system (Linux, Windows, ...) and version?
Windows 11

What did you do?
Steps to reproduce the behavior:
Run this code:

#!/usr/bin/env python3
# This Python file uses the following encoding: utf-8
# Copyright 2015 Tin Arm Engineering AB
# Copyright 2018 Google LLC
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Capacitated Vehicle Routing Problem (CVRP).

   This is a sample using the routing library python wrapper to solve a CVRP
   problem while allowing multiple trips, i.e., vehicles can return to a depot
   to reset their load ("reload").

   A description of the CVRP problem can be found here:
   http://en.wikipedia.org/wiki/Vehicle_routing_problem.

   Distances are in meters.

   In order to implement multiple trips, new nodes are introduced at the same
   locations of the original depots. These additional nodes can be dropped
   from the schedule at 0 cost.

   The max_slack parameter associated to the capacity constraints of all nodes
   can be set to be the maximum of the vehicles' capacities, rather than 0 like
   in a traditional CVRP. Slack is required since before a solution is found,
   it is not known how much capacity will be transferred at the new nodes. For
   all the other (original) nodes, the slack is then re-set to 0.

   The above two considerations are implemented in `add_capacity_constraints()`.

   Last, it is useful to set a large distance between the initial depot and the
   new nodes introduced, to avoid schedules having spurious transits through
   those new nodes unless it's necessary to reload. This consideration is taken
   into account in `create_distance_evaluator()`.
"""


from functools import partial

from ortools.constraint_solver import pywrapcp
from ortools.constraint_solver import routing_enums_pb2


###########################
# Problem Data Definition #
###########################
def create_data_model():
    """Stores the data for the problem"""
    data = {}
    _capacity = 8
    data['demands'] = \
          [0, # depot
           -_capacity, # unload depot_first
           -_capacity, # unload depot_second
           -_capacity, # unload depot_third
           -_capacity, # unload depot_fourth
           -_capacity, # unload depot_fifth
           8, 8, # 1, 2
           8, 8, # 3, 4
           8]    # 5
    data['num_locations'] = len(data['demands'])
    data['time_per_demand_unit'] = 5  # 5 minutes/unit
    data['time_windows'] = \
          [(0, 0), # depot
           (0, 1000), # unload depot_first
           (0, 1000), # unload depot_second
           (0, 1000), # unload depot_third
           (0, 1000), # unload depot_fourth
           (0, 1000), # unload depot_fifth
           (0, 1000), (0, 1000), # 1, 2
           (0, 1000), (0, 1000), # 3, 4
           (0, 1000)]             # 5
    data['vehicle_capacity'] = _capacity
    data['num_vehicles'] = 5
    data['vehicle_max_distance'] = 10_000
    data['vehicle_max_time'] = 1_500
    data['depot'] = 0
    return data


#######################
# Problem Constraints #
#######################
def create_distance_evaluator(data):
    """Creates callback to return distance between points."""
    _distances = {}
    # precompute distance between location to have distance callback in O(1)
    for from_node in range(data['num_locations']):
        _distances[from_node] = {}
        for to_node in range(data['num_locations']):
            if from_node == to_node:
                _distances[from_node][to_node] = 0
            # Forbid start/end/reload node to be consecutive.
            elif from_node in range(6) and to_node in range(6):
                _distances[from_node][to_node] = data['vehicle_max_distance']
            else:
                _distances[from_node][to_node] = 1

    def distance_evaluator(manager, from_node, to_node):
        return _distances[manager.IndexToNode(from_node)][manager.IndexToNode(
            to_node)]

    return distance_evaluator


def add_distance_dimension(routing, manager, data, distance_evaluator_index):
    """Add Global Span constraint"""
    distance = 'Distance'
    routing.AddDimension(
        distance_evaluator_index,
        0,  # null slack
        data['vehicle_max_distance'],  # maximum distance per vehicle
        True,  # start cumul to zero
        distance)


def create_demand_evaluator(data):
    """Creates callback to get demands at each location."""
    _demands = data['demands']

    def demand_evaluator(manager, from_node):
        """Returns the demand of the current node"""
        return _demands[manager.IndexToNode(from_node)]

    return demand_evaluator


def add_capacity_constraints(routing:pywrapcp.RoutingModel, manager: pywrapcp.RoutingIndexManager, data, demand_evaluator_index):
    """Adds capacity constraint"""
    vehicle_capacity = data['vehicle_capacity']
    capacity = 'Capacity'
    routing.AddDimension(
        demand_evaluator_index,
        vehicle_capacity,
        vehicle_capacity,
        True,  # start cumul to zero
        capacity)

    # Add Slack for reseting to zero unload depot nodes.
    # e.g. vehicle with load 10/15 arrives at node 1 (depot unload)
    # so we have CumulVar = 10(current load) + -15(unload) + 5(slack) = 0.
    capacity_dimension = routing.GetDimensionOrDie(capacity)
    # Allow to drop reloading nodes with zero cost.
    for node in [1, 2, 3, 4, 5]:
        node_index = manager.NodeToIndex(node)
        routing.AddDisjunction([node_index], 0)

    # Allow to drop regular node with a cost.
    for node in range(6, len(data['demands'])):
        node_index = manager.NodeToIndex(node)
        capacity_dimension.SlackVar(node_index).SetValue(0)
        routing.AddDisjunction([node_index], 100_000)


def create_time_evaluator(data):
    """Creates callback to get total times between locations."""

    def service_time(data, node):
        """Gets the service time for the specified location."""
        # return abs(data['demands'][node]) * data['time_per_demand_unit']
        return 0

    def travel_time(data, from_node, to_node):
        """Gets the travel times between two locations."""
        if from_node == to_node:
            travel_time = 0
        else:
            travel_time = 1
        return travel_time

    _total_time = {}
    # precompute total time to have time callback in O(1)
    for from_node in range(data['num_locations']):
        _total_time[from_node] = {}
        for to_node in range(data['num_locations']):
            if from_node == to_node:
                _total_time[from_node][to_node] = 0
            else:
                _total_time[from_node][to_node] = int(
                    service_time(data, from_node) + travel_time(
                        data, from_node, to_node))

    def time_evaluator(manager, from_node, to_node):
        """Returns the total time between the two nodes"""
        return _total_time[manager.IndexToNode(from_node)][manager.IndexToNode(
            to_node)]

    return time_evaluator


def add_time_window_constraints(routing, manager, data, time_evaluator):
    """Add Time windows constraint"""
    time = 'Time'
    max_time = data['vehicle_max_time']
    routing.AddDimension(
        time_evaluator,
        max_time,  # allow waiting time
        max_time,  # maximum time per vehicle
        False,  # don't force start cumul to zero since we are giving TW to start nodes
        time)
    time_dimension = routing.GetDimensionOrDie(time)
    # Add time window constraints for each location except depot
    # and 'copy' the slack var in the solution object (aka Assignment) to print it
    for location_idx, time_window in enumerate(data['time_windows']):
        if location_idx == 0:
            continue
        index = manager.NodeToIndex(location_idx)
        time_dimension.CumulVar(index).SetRange(time_window[0], time_window[1])
        routing.AddToAssignment(time_dimension.SlackVar(index))
    # Add time window constraints for each vehicle start node
    # and 'copy' the slack var in the solution object (aka Assignment) to print it
    for vehicle_id in range(data['num_vehicles']):
        index = routing.Start(vehicle_id)
        time_dimension.CumulVar(index).SetRange(data['time_windows'][0][0],
                                                data['time_windows'][0][1])
        routing.AddToAssignment(time_dimension.SlackVar(index))
        # Warning: Slack var is not defined for vehicle's end node
        #routing.AddToAssignment(time_dimension.SlackVar(self.routing.End(vehicle_id)))


###########
# Printer #
###########
def print_solution(data, manager, routing, assignment):  # pylint:disable=too-many-locals
    """Prints assignment on console"""
    print(f'Objective: {assignment.ObjectiveValue()}')
    total_distance = 0
    total_load = 0
    total_time = 0
    capacity_dimension = routing.GetDimensionOrDie('Capacity')
    distance_dimension = routing.GetDimensionOrDie('Distance')
    time_dimension = routing.GetDimensionOrDie('Time')
    dropped = []
    for order in range(6, routing.nodes()):
        index = manager.NodeToIndex(order)
        if assignment.Value(routing.NextVar(index)) == index:
            dropped.append(order)
    print(f'dropped orders: {dropped}')
    dropped = []
    for reload in range(1, 6):
        index = manager.NodeToIndex(reload)
        if assignment.Value(routing.NextVar(index)) == index:
            dropped.append(reload)
    print(f'dropped reload stations: {dropped}')

    for vehicle_id in range(data['num_vehicles']):
        index = routing.Start(vehicle_id)
        if routing.IsEnd(assignment.Value(routing.NextVar(index))):
            continue
        plan_output = f'Route for vehicle {vehicle_id}:\n'
        while not routing.IsEnd(index):
            load_var = capacity_dimension.CumulVar(index)
            time_var = time_dimension.CumulVar(index)
            plan_output += ' {0} Load({1}) Time({2},{3}) ->'.format(
                manager.IndexToNode(index),
                assignment.Value(load_var),
                assignment.Min(time_var), assignment.Max(time_var))
            # previous_index = index
            index = assignment.Value(routing.NextVar(index))
        load_var = capacity_dimension.CumulVar(index)
        time_var = time_dimension.CumulVar(index)
        plan_output += ' {0} Load({1}) Time({2},{3})\n'.format(
            manager.IndexToNode(index),
            assignment.Value(load_var),
            assignment.Min(time_var), assignment.Max(time_var))
        plan_output += f'Distance of the route: {assignment.Value(distance_dimension.CumulVar(index))}m\n'
        plan_output += f'Load of the route: {assignment.Value(load_var)}\n'
        plan_output += f'Time of the route: {assignment.Value(time_var)}min\n'
        print(plan_output)
        total_distance += assignment.Value(distance_dimension.CumulVar(index))
        total_load += assignment.Value(load_var)
        total_time += assignment.Value(time_var)
    print('Total Distance of all routes: {}m'.format(total_distance))
    print('Total Load of all routes: {}'.format(total_load))
    print('Total Time of all routes: {}min'.format(total_time))


########
# Main #
########
def main():
    """Entry point of the program"""
    # Instantiate the data problem.
    data = create_data_model()

    # Create the routing index manager
    manager = pywrapcp.RoutingIndexManager(data['num_locations'],
                                           data['num_vehicles'], data['depot'])

    # Create Routing Model
    routing = pywrapcp.RoutingModel(manager)

    # Define weight of each edge
    distance_evaluator_index = routing.RegisterTransitCallback(
        partial(create_distance_evaluator(data), manager))
    routing.SetFixedCostOfAllVehicles(1000)
    routing.SetArcCostEvaluatorOfAllVehicles(distance_evaluator_index)

    # Add Distance constraint to minimize the longuest route
    add_distance_dimension(routing, manager, data, distance_evaluator_index)

    # Add Capacity constraint
    demand_evaluator_index = routing.RegisterUnaryTransitCallback(
        partial(create_demand_evaluator(data), manager))
    add_capacity_constraints(routing, manager, data, demand_evaluator_index)

    # Add Time Window constraint
    time_evaluator_index = routing.RegisterTransitCallback(
        partial(create_time_evaluator(data), manager))
    add_time_window_constraints(routing, manager, data, time_evaluator_index)

    # Setting first solution heuristic (cheapest addition).
    search_parameters = pywrapcp.DefaultRoutingSearchParameters()
    search_parameters.first_solution_strategy = (
        routing_enums_pb2.FirstSolutionStrategy.AUTOMATIC)  # pylint: disable=no-member
    search_parameters.local_search_metaheuristic = (
        routing_enums_pb2.LocalSearchMetaheuristic.GUIDED_LOCAL_SEARCH)
    search_parameters.time_limit.FromSeconds(3)

    # Solve the problem.
    solution = routing.SolveWithParameters(search_parameters)
    if solution:
        print_solution(data, manager, routing, solution)
    else:
        print("No solution found !")


if __name__ == '__main__':
    main()

The code is adapted from cvrp_reload.py
What did you expect to see
One truck delivering all the orders reducing total fixed costs.

Case in point which proves that it is a bug: If I reduce the number of vehicles to 1 (i.e. data['num_vehicles'] = 1) then I get the proper output:

Objective: 1010
dropped orders: []
dropped reload stations: [5]
Route for vehicle 0:
 0 Load(0) Time(0,0) -> 9 Load(0) Time(1,992) -> 4 Load(8) Time(2,993) -> 8 Load(0) Time(3,994) -> 3 Load(8) Time(4,995) -> 7 Load(0) Time(5,996) -> 2 Load(8) Time(6,997) -> 6 Load(0) Time(7,998) -> 1 Load(8) Time(8,999) -> 10 Load(0) Time(9,1000) -> 0 Load(8) Time(10,1500)
Distance of the route: 10m
Load of the route: 8
Time of the route: 10min

Total Distance of all routes: 10m
Total Load of all routes: 8
Total Time of all routes: 10min

What did you see instead?
This output:

Objective: 5010
dropped orders: []
dropped reload stations: [1, 2, 3, 4, 5]
Route for vehicle 0:
 0 Load(0) Time(0,0) -> 6 Load(0) Time(1,1000) -> 0 Load(8) Time(2,1500)
Distance of the route: 2m
Load of the route: 8
Time of the route: 2min

Route for vehicle 1:
 0 Load(0) Time(0,0) -> 7 Load(0) Time(1,1000) -> 0 Load(8) Time(2,1500)
Distance of the route: 2m
Load of the route: 8
Time of the route: 2min

Route for vehicle 2:
 0 Load(0) Time(0,0) -> 8 Load(0) Time(1,1000) -> 0 Load(8) Time(2,1500)
Distance of the route: 2m
Load of the route: 8
Time of the route: 2min

Route for vehicle 3:
 0 Load(0) Time(0,0) -> 9 Load(0) Time(1,1000) -> 0 Load(8) Time(2,1500)
Distance of the route: 2m
Load of the route: 8
Time of the route: 2min

Route for vehicle 4:
 0 Load(0) Time(0,0) -> 10 Load(0) Time(1,1000) -> 0 Load(8) Time(2,1500)
Distance of the route: 2m
Load of the route: 8
Time of the route: 2min

Total Distance of all routes: 10m
Total Load of all routes: 40
Total Time of all routes: 10min

Tried increasing the time limit to 30 seconds. Still the same thing.

Make sure you include information that can help us debug (full error message, model Proto).
NA

Anything else we should know about your project / environment
NA

[arnabanimesh]

The routing solver generates a very bad solution in this simple scenario.

One truck could have visited all the places and total cost would have been a little over 1000 instead of the current 5000+.

Linked issue: #4515

[jmarca]

try removing the line

distance_dimension.SetGlobalSpanCostCoefficient(100)

[arnabanimesh]

distance and time is practically nil. Tried removing the line, doesn't work. I have updated the code.

[arnabanimesh]

I will provide a test which will prove that it is a bug. Just reduce the number of vehicles to 1 (i.e. data['num_vehicles'] = 1). Then you will get the proper output which costs to 1010 instead of 5010.

The cost is after I removed the line distance_dimension.SetGlobalSpanCostCoefficient(100).

[arnabanimesh]

I have updated the code to show this scenario.

[arnabanimesh]

@lperron @Mizux It is most definitely a bug. Please check the What did you expect to see section which proves that it is indeed a bug.

[arnabanimesh]

@lperron can anything be done? Or should I consider that this issue will remain in the foreseeable future?