Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf counter tracks are missing the cpu number #1008

Closed
gramound opened this issue Feb 10, 2025 · 3 comments
Closed

Perf counter tracks are missing the cpu number #1008

gramound opened this issue Feb 10, 2025 · 3 comments

Comments

@gramound
Copy link
Contributor

I noticed the "Cpu N " prefix is missing in the perf counter tracks.

Example before the rewrite:

Image
@stevegolton
Copy link
Member

Hey, thanks for raising the bug. I can repro and have a fix available here.

primiano pushed a commit that referenced this issue Feb 12, 2025
@stevegolton
ui: Create a new plugin for linux perf
6becd7a 
This includes:
- perf counters
- callstack samples

The motivation behind this is to take control of how perf counter
tracks are displayed rather than leaving it up to the generic counter
track plugin. This fixes a bug where perf counter tracks no longer
have the CPU number in the title.

Bug: #1008
Change-Id: Ie66727ecbeb7eda737648cd9124b6a51acd8d229
@stevegolton
Copy link
Member

This fix should be available on the stable and autopush channels shortly.

I'm afraid it's not a trivial cherry pick onto stable, so I think you'll have to wait until the next stable release which will be the beginning of march. Feel free to use the canary channel for now.

@gramound
Copy link
Contributor Author

That works for me, thanks Steve!

Image

jrguzman-ms pushed a commit to msft-mirror-aosp/platform.external.perfetto that referenced this issue Feb 19, 2025
@stevegolton
ui: Create a new plugin for linux perf
d3b7728 
This includes:
- perf counters
- callstack samples

The motivation behind this is to take control of how perf counter
tracks are displayed rather than leaving it up to the generic counter
track plugin. This fixes a bug where perf counter tracks no longer
have the CPU number in the title.

Bug: google/perfetto#1008
Change-Id: Ie66727ecbeb7eda737648cd9124b6a51acd8d229
(cherry picked from commit 6becd7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevegolton @gramound @aMayzner