Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WooCommerce Redirect Modal Trigger Logic for Ads Module Setup via Settings #10178

Closed
1 task
10upsimon opened this issue Feb 5, 2025 · 1 comment
Closed
1 task
Assignees
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@10upsimon
Copy link
Collaborator

10upsimon commented Feb 5, 2025

Feature Description

The WooCommerce redirect modal should be triggered as early as possible for users opting to setup ads and whom meet the criteria of the modal, hence the triggering of this banner from the Ads Module Setup CTA Banner as well, see #10175.

Another early capture point is the Settings > Connect More Services view, where the WooCommerce Redirect Modal should be triggered when said qualifying users click on the "Set up Ads" CTA, as per the below screenshot:

image.png

The modal should be triggered for users satisfying any of the following criteria:

The user has WooCommerce installed but not Google for WooCommerce

image.png

The user has both WooCommerce & Google for WooCommerce installed, but no Ads account linked via Google for WooCommerce

image.png

####The user has both WooCommerce & Google for WooCommerce installed, and has an Ads account linked via Google for WooCommerce
image.png

In all 3 of the above cases, the user should be given a choice to proceed with setting up Ads using Site Kit, via the secondary CTA of the modal. The primary CTA of each modal will be controlled by the modal component itself.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@10upsimon 10upsimon added javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Feb 5, 2025
@10upsimon 10upsimon assigned 10upsimon and zutigrm and unassigned 10upsimon Feb 5, 2025
@10upsimon
Copy link
Collaborator Author

Triggering has also been outlined in #10172 so this issue is being closed out, cc @binnieshah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants