An error occurred while running ‘mapSelect’: Cannot read properties of undefined (reading ‘forEach’)

[jamesozzie]

Bug Description

A couple of support topics were opened - although likely from admins of the same site, whereby the following dashboard error appears:
An error occurred while running ‘mapSelect’: Cannot read properties of undefined (reading ‘forEach’)

They mentioned that this occurred only after updating to the latest version of Site Kit (1.145.0).

Full error as reported in the forums:

An error occurred while running ‘mapSelect’: Cannot read properties of undefined (reading ‘forEach’)
The error may be correlated with this previous error:
TypeError: Cannot read properties of undefined (reading ‘forEach’)
at https://trinityua.com/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-modules-analytics-4-e7215bb257eaff98a241.js:130:106266
at Array.forEach ()

• Support topic one: The user states that the only fix is disconnecting GA from within Site Kit
• Support topic two: No response from user

This specific error was also raised by @wpdarren in Slack (link)

Within that discussion on this error, a recording with details was included.

Additional Context

• SK 1.145.0
• Awaiting response from impacted user
• Site Health information from impacted site found here

cc. @aaemnnosttv

@wpdarren observed this independently in his own testing but was unable to reproduce

An error occurred while running 'mapSelect': Cannot read properties of undefined (reading 'forEach')
The error may be correlated with this previous error:
TypeError: Cannot read properties of undefined (reading 'forEach')
    at https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-modules-analytics-4-481b89c2cd44559a7bb4.js:132:106952
    at Array.forEach (<anonymous>)
    at qn.getAnalyticsConfigByMeasurementIDs (https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-modules-analytics-4-481b89c2cd44559a7bb4.js:132:106899)
    at t (https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-vendor-55f6d4109c59b75ef2bd.js:7:30983)
    at https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-vendor-55f6d4109c59b75ef2bd.js:7:486663
    at Object.n [as getAnalyticsConfigByMeasurementIDs] (https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-vendor-55f6d4109c59b75ef2bd.js:7:486228)
    at Object.current (https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-main-dashboard-a4bcd8e2d49c8c193c4e.js:94:8505)
    at e (https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-vendor-55f6d4109c59b75ef2bd.js:7:197958)
    at https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-vendor-55f6d4109c59b75ef2bd.js:7:198121
    at https://site-kit-146.instawp.xyz/wp-content/plugins/google-site-kit/dist/assets/js/googlesitekit-vendor-55f6d4109c59b75ef2bd.js:7:491524
Original stack trace:
    in GoogleTagIDMismatchNotification
    in BannerNotifications
    in div
    in Header
    in DashboardMainApp
    in DashboardEntryPoint
    in RestoreSnapshots
    in ErrorHandler
    in ThemeProvider
    in StrictMode
    in Root

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Audit the analytics-4 code base, particularly the datastore + getAnalyticsConfigByMeasurementIDs selector for instances of forEach on values which may not be defined
  • For each, reproduce the error with a test and fix

Implementation Brief

• Update getAnalyticsConfigByMeasurementIDs to handle cases where an account summary may not have any propertySummaries as these are not set if the account has none
• Finish and merge Fix/10187-forEach-error #10192

Test Coverage

• Update coverage for areas identified above

QA Brief

1. Setup Site Kit with Analytics.
2. Go to Site Kit settings for Analytics and edit, then create a new Analytics account.
3. Enter a account, property and web data stream name.
4. Disable the Enhanced Measurement toggle. (I will see if the same happens with this enabled)
5. You’ll go through the steps to create a new Analytics account. Click the button to go back to the dashboard.
6. Wait for 10 seconds and ensure no fatal errors appear.

Changelog entry

• Fix error that could occur on the dashboard when connecting a new Analytics account after connecting a previously-connected account.

[aaemnnosttv]

Sending to IBR as I'm not sure there are any other instances where this could be raised, and I was able to reproduce the same error in a test. The reported error is wrapped in "mapSelect" which just means the underlying error was raised within.

[mohitwp]

I'm able simulate this on one older site. The only difference I’ve noticed is that on the site where this error is appearing, I created multiple analytics accounts yesterday as part of the process to recreate this issue.

[aaemnnosttv]

Moving to CR for potential inclusion in release