Update the js tests action to retry it up to 3 times if tests fail for the first time

[eugene-manuilov]

Feature Description

Our js tests tend to fail on a random basis caused by some sporadic timeouts that is hard to troubleshoot and fix. We need to repeat failed tests on failure to increase the chance of passing js tests without a need to manually restart it.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• JS tests retries up to 3 times if the first run fails
• Subsequent runs check only failed tests

Implementation Brief

• Update jest tests step

  site-kit-wp/.github/workflows/js-css-lint-test.yml

  Lines 75 to 76 in 370ca1c

  	- name: Jest Tests
  	run: npm run test:js

  • Remove the run command
  • Add uses: nick-fields/retry@v3 with the following properties (docs):
    • max_attempts: 3
    • timeout_minutes: 15
    • command: "npm run test:js"
    • retry_on: error
    • retry_wait_seconds: 0
    • new_command_on_retry: "npm run test:js -- --onlyFailures"

Test Coverage

• N/A

QA Brief

Changelog entry

[eugene-manuilov]

@aaemnnosttv @tofumatt @nfmohit @techanvil do you mind reviewing IB?

[techanvil]

Sure, @eugene-manuilov, this is looking good. A couple of small points:

• The docs for nick-fields/retry@v3 state that retry_wait_seconds has a default of 10. I don't think we need to wait 10 seconds to retry, so would suggest we provide a lower value for this setting.
• The docs don't have the commands quoted - I'm not sure if it makes a difference but would suggest updating to e.g. command: npm run test:js for consistency with the docs.

[eugene-manuilov]

• The docs for nick-fields/retry@v3 state that retry_wait_seconds has a default of 10. I don't think we need to wait 10 seconds to retry, so would suggest we provide a lower value for this setting.

Nicely spotted. Updated IB to wait 0 seconds between retries.

• The docs don't have the commands quoted - I'm not sure if it makes a difference but would suggest updating to e.g. command: npm run test:js for consistency with the docs.

The commands are quoted to escape colons that we have there. This is yaml stuff. Might not be really necessary, but better to use it to escape strings just in case.

[techanvil]

Thanks @eugene-manuilov. Good point, the commands should simply be treated as strings either way so quoting should be OK.

IB ✅