Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate Ads Module Setup CTA Banner (Pax Pilot V2) #10217

Closed
1 task
10upsimon opened this issue Feb 13, 2025 · 1 comment
Closed
1 task

Reinstate Ads Module Setup CTA Banner (Pax Pilot V2) #10217

10upsimon opened this issue Feb 13, 2025 · 1 comment
Assignees
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Feature New feature

Comments

@10upsimon
Copy link
Collaborator

Feature Description

With the removal of the Ads PAX pilot banner prompting users to download the pilot mini plugin, there should be some form of CTA banner prompting Ads module set up.

The existing Ads Module Setup CTA banner at assets/js/components/notifications/AdsModuleSetupCTAWidget.js should be updated and re-instated to achieve this, but it is important to note that there is already an issue, #10175, that does this exact same thing for the WooCommerce Redirect epic.

#10175 should therefore likely be a blocker to this issue, and adapted accordingly should this body of work release prior to that epic, OR, the bulk of the refactoring work identified within #10175 should be executed on in this issue (less the modal triggering) and become a blocker to #10175.

image.png


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@10upsimon 10upsimon added javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Feature New feature labels Feb 13, 2025
@10upsimon 10upsimon self-assigned this Feb 13, 2025
@10upsimon
Copy link
Collaborator Author

Closing as this is completely satisfied by #10175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant