Skip to content

Commit 7079f8b

Browse files
ZetaSQL Teamapilloud
ZetaSQL Team
authored andcommitted
Export of internal ZetaSQL changes.
- Update documentation for contributors. by Andrew Pilloud <[email protected]> - Remove hardcoded physical byte sizes from Value tests. by ZetaSQL Team <[email protected]> GitOrigin-RevId: 2fd2dab16ac49d1aa5602361e65e3ae5b0d37887 Change-Id: Id7dcb133b21545d3a553040d8f6105f2c0c6be6b
1 parent 98af7e3 commit 7079f8b

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

CONTRIBUTING.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,20 @@
11
# How to Contribute
22

3-
We are not currently accepting contributions to this project.
3+
We are not currently accepting external code contributions to this project.
4+
Please feel free to file bugs and feature requests using
5+
[GitHub's issue tracker] (https://github.com/google/zetasql/issues/new)
6+
7+
## Contributor License Agreement
8+
9+
Contributions to this project must be accompanied by a Contributor License
10+
Agreement. You (or your employer) retain the copyright to your contribution,
11+
this simply gives us permission to use and redistribute your contributions as
12+
part of the project. Head over to <https://cla.developers.google.com/> to see
13+
your current agreements on file or to sign a new one.
14+
15+
You generally only need to submit a CLA once, so if you've already submitted
16+
one (even if it was for a different project), you probably don't need to do it
17+
again.
418

519
## Community Guidelines
620

PULL_REQUEST_TEMPLATE.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
We are not currently accepting external code contributions to this project.
2+
Please feel free to file bugs and feature requests using GitHub's issue tracker.
3+
4+
Also see: https://github.com/google/zetasql/blob/master/CONTRIBUTING.md

zetasql/public/value.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,9 @@ class Value {
394394
const Type* type);
395395

396396
private:
397+
// For access to StringRef and TypedList.
398+
FRIEND_TEST(ValueTest, PhysicalByteSize);
399+
397400
template <typename H>
398401
H HashValueInternal(H h) const;
399402

0 commit comments

Comments
 (0)