-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
good first issueThis issue is a good place to started contributing to this repository.This issue is a good place to started contributing to this repository.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
The following code:
gapic-generator-php/src/Generation/BuildMethodFragmentGenerator.php
Lines 135 to 141 in 277c703
| if (count($methodSignatureArguments) !== $requiredFields->count()) { | |
| throw new \LogicException(sprintf( | |
| 'missing method signature arguments (Expected "%s", found %s)', | |
| $methodSignature, | |
| implode(',', $requiredFields->map(fn ($f) => $f->name)->toArray()) ?: 'none' | |
| )); | |
| } |
Does not account for a signature like "foo.a,foo.b" where foo is a google.api.field_behavior = REQUIRED field. The presence of foo.a should be sufficient.
Furthermore, we need to make sure that build fragment generation can handle a dot-notation signature!
Metadata
Metadata
Assignees
Labels
good first issueThis issue is a good place to started contributing to this repository.This issue is a good place to started contributing to this repository.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.