Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the client library with OpenCensus for C++ #571

Closed
coryan opened this issue May 25, 2018 · 6 comments
Closed

Integrate the client library with OpenCensus for C++ #571

coryan opened this issue May 25, 2018 · 6 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented May 25, 2018

All operations should be integrated with OpenCensus for C++. This is probably blocked by abseil/abseil-cpp#111 because OpenCensus depends on Abseil.

@coryan coryan added the api: storage Issues related to the Cloud Storage API. label May 25, 2018
@coryan coryan added this to the Google Cloud Storage - Advanced Features milestone May 25, 2018
@g-easy
Copy link

g-easy commented Aug 1, 2018

OpenCensus C++ already builds with bazel. (census-instrumentation/opencensus-cpp#86 tracks cmake support)

Can we get google-cloud-cpp + opencensus-cpp building with bazel?

@coryan
Copy link
Contributor Author

coryan commented Aug 1, 2018

Can we get google-cloud-cpp + opencensus-cpp building with bazel?

Yes. We built a prototype actually:

https://github.com/coryan/google-cloud-cpp/blob/prototype-opencensus/google/cloud/bigtable/examples/bigtable_opencensus.cc

In principle, you can setup a WORKSPACE that pulls the right versions today and get it to work. Now that grpc v1.14.x is out we should probably have an example that shows that.

@coryan
Copy link
Contributor Author

coryan commented Aug 1, 2018

I just created #957 and #958 to track this.

@coryan
Copy link
Contributor Author

coryan commented Aug 1, 2018

Oh, this bug is for the storage client. I was thinking Bigtable. For the storage client we need to do more development. There is no gRPC API for GCS, so we are using libcurl. I am sure it is still possible to integrate with OpenCensus via Bazel, but it would be more work.

Notice that in either case it would be hard to do a deeper integration in the library without CMake support. We can build a demo that links (and uses) OpenCensus, but we cannot have the library create spans for a single logical operation that is retried multiple times (for example), because that wouldn't link when the client library is compiled with CMake, and we are not really looking forward to peppering the code with #ifdefs.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 24, 2019
@coryan coryan added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed size: unknown 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 31, 2019
@devjgm
Copy link
Contributor

devjgm commented May 12, 2020

FWIW, we have a dep on Abseil now, so that should no longer be a blocker.

@coryan
Copy link
Contributor Author

coryan commented Jan 14, 2021

This is now obsolete. OpenCensus for C++ does not seem to be under active development after the "merge" into OpenTelemetry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants