-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the client library with OpenCensus for C++ #571
Comments
OpenCensus C++ already builds with bazel. (census-instrumentation/opencensus-cpp#86 tracks cmake support) Can we get google-cloud-cpp + opencensus-cpp building with bazel? |
Yes. We built a prototype actually: In principle, you can setup a WORKSPACE that pulls the right versions today and get it to work. Now that grpc v1.14.x is out we should probably have an example that shows that. |
Oh, this bug is for the storage client. I was thinking Bigtable. For the storage client we need to do more development. There is no gRPC API for GCS, so we are using libcurl. I am sure it is still possible to integrate with OpenCensus via Bazel, but it would be more work. Notice that in either case it would be hard to do a deeper integration in the library without CMake support. We can build a demo that links (and uses) OpenCensus, but we cannot have the library create spans for a single logical operation that is retried multiple times (for example), because that wouldn't link when the client library is compiled with CMake, and we are not really looking forward to peppering the code with |
FWIW, we have a dep on Abseil now, so that should no longer be a blocker. |
This is now obsolete. OpenCensus for C++ does not seem to be under active development after the "merge" into OpenTelemetry. |
All operations should be integrated with OpenCensus for C++. This is probably blocked by abseil/abseil-cpp#111 because OpenCensus depends on Abseil.
The text was updated successfully, but these errors were encountered: