Skip to content

Deprecate and remove AsyncRowReader from the public API #8853

@dbolduc

Description

@dbolduc

The public part of this class is just one static variable.

template <typename RowFunctor, typename FinishFunctor>
class AsyncRowReader : public std::enable_shared_from_this<
AsyncRowReader<RowFunctor, FinishFunctor>> {
public:
/// Special value to be used as rows_limit indicating no limit.
// NOLINTNEXTLINE(readability-identifier-naming)
static std::int64_t constexpr NO_ROWS_LIMIT = 0;
// Callbacks keep pointers to these objects.
AsyncRowReader(AsyncRowReader&&) = delete;
AsyncRowReader(AsyncRowReader const&) = delete;

I think we should just deprecate it and point customers to RowReader::NO_ROWS_LIMIT.

static std::int64_t constexpr NO_ROWS_LIMIT = 0;

(The AsyncRowReader implementation gets moved into bigtable/internal/async_row_reader.h)

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the Bigtable API.next major: breaking changethis is a change that we should wait to bundle into the next major versiontype: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions