-
Notifications
You must be signed in to change notification settings - Fork 436
Closed
Labels
api: bigtableIssues related to the Bigtable API.Issues related to the Bigtable API.next major: breaking changethis is a change that we should wait to bundle into the next major versionthis is a change that we should wait to bundle into the next major versiontype: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Milestone
Description
The public part of this class is just one static variable.
google-cloud-cpp/google/cloud/bigtable/async_row_reader.h
Lines 47 to 57 in a24af94
| template <typename RowFunctor, typename FinishFunctor> | |
| class AsyncRowReader : public std::enable_shared_from_this< | |
| AsyncRowReader<RowFunctor, FinishFunctor>> { | |
| public: | |
| /// Special value to be used as rows_limit indicating no limit. | |
| // NOLINTNEXTLINE(readability-identifier-naming) | |
| static std::int64_t constexpr NO_ROWS_LIMIT = 0; | |
| // Callbacks keep pointers to these objects. | |
| AsyncRowReader(AsyncRowReader&&) = delete; | |
| AsyncRowReader(AsyncRowReader const&) = delete; | |
I think we should just deprecate it and point customers to RowReader::NO_ROWS_LIMIT.
| static std::int64_t constexpr NO_ROWS_LIMIT = 0; |
(The AsyncRowReader implementation gets moved into bigtable/internal/async_row_reader.h)
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the Bigtable API.Issues related to the Bigtable API.next major: breaking changethis is a change that we should wait to bundle into the next major versionthis is a change that we should wait to bundle into the next major versiontype: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.