Skip to content

Deprecate and remove public RowReader ctors #8854

@dbolduc

Description

@dbolduc

These constructors do not need to be public:

RowReader(std::shared_ptr<DataClient> client, std::string table_name,
RowSet row_set, std::int64_t rows_limit, Filter filter,
std::unique_ptr<RPCRetryPolicy> retry_policy,
std::unique_ptr<RPCBackoffPolicy> backoff_policy,
MetadataUpdatePolicy metadata_update_policy,
std::unique_ptr<internal::ReadRowsParserFactory> parser_factory);
RowReader(std::shared_ptr<DataClient> client, std::string app_profile_id,
std::string table_name, RowSet row_set, std::int64_t rows_limit,
Filter filter, std::unique_ptr<RPCRetryPolicy> retry_policy,
std::unique_ptr<RPCBackoffPolicy> backoff_policy,
MetadataUpdatePolicy metadata_update_policy,
std::unique_ptr<internal::ReadRowsParserFactory> parser_factory);

We will deprecate them and schedule their deletion date as 2023-05-01 (same as #8800)

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the Bigtable API.next major: breaking changethis is a change that we should wait to bundle into the next major versiontype: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions