Skip to content

Commit b679835

Browse files
authored
fix(ci): fix java-cloud-bom release-notes workflow errors (#13682)
Resolves java-cloud-bom release-notes GHA workflow failures by: 1. Correcting the working directory and POM paths inside the workflow file. 2. Adjusting the regex pattern in the version parser to prevent greedy comment-matching. 3. Updating `ReleaseNoteGeneration.java` to skip split-repository release page queries for migrated client libraries (bigtable, firestore, pubsub, and pubsublite). Verifications: * Manual GHA verification run: https://github.com/googleapis/google-cloud-java/actions/runs/28888992080 (Success) * Updated release page: https://github.com/googleapis/google-cloud-java/releases/tag/libraries-bom/v26.85.0 b/532119638
1 parent 7e57092 commit b679835

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

.github/workflows/java-cloud-bom-release-note-generation.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ jobs:
5858
shell: bash
5959
run: |
6060
set -x
61-
mvn -B -ntp compile -f java-cloud-bom/release-note-generation/pom.xml
61+
mvn -B -ntp compile
6262
6363
GOOGLE_CLOUD_JAVA_VERSION=$(grep -A1 'gapic-libraries-bom' \
64-
../google-cloud-bom/pom.xml |perl -nle 'print $1 if m/<version>(.+)</')
64+
../google-cloud-bom/pom.xml |perl -nle 'print $1 if m/<version>([^<]+)</')
6565
6666
# This generates release_note.md file
67-
mvn -B -ntp exec:java -f java-cloud-bom/release-note-generation/pom.xml \
67+
mvn -B -ntp exec:java \
6868
-Dlibraries-bom.version="${LIBRARIES_BOM_VERSION}" \
6969
-Dgoogle-cloud-java.version="${GOOGLE_CLOUD_JAVA_VERSION}"
7070
working-directory: java-cloud-bom/release-note-generation

java-cloud-bom/release-note-generation/src/main/java/com/google/cloud/ReleaseNoteGeneration.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@ public class ReleaseNoteGeneration {
6262
private static final String RELEASE_NOTE_FILE_NAME = "release_note.md";
6363
private static final String GOOGLEAPIS_ORG = "googleapis";
6464

65-
private static final ImmutableSet<String> splitRepositoryLibraryNames =
66-
ImmutableSet.of("bigtable", "firestore", "pubsub", "pubsublite");
65+
private static final ImmutableSet<String> splitRepositoryLibraryNames = ImmutableSet.of();
6766

6867
private static boolean clientLibraryFilter(String coordinates) {
6968
if (coordinates.contains("google-cloud-core")) {

0 commit comments

Comments
 (0)