remove timestamp from format_date support

Author: tswast

packages/bigframes/bigframes/extensions/core/series_accessor.py

@@ -1062,11 +1062,6 @@ def format_date(
             bigframes.core.col.Expression,
             Union[Literal[sentinels.Sentinel.ARGUMENT_DEFAULT], str],
         ],
-        time_zone: Union[
-            series.Series,
-            bigframes.core.col.Expression,
-            Union[Literal[sentinels.Sentinel.ARGUMENT_DEFAULT], str],
-        ] = sentinels.Sentinel.ARGUMENT_DEFAULT,
         *,
         session: Optional[bigframes.session.Session] = None,
     ) -> S:
@@ -1081,14 +1076,12 @@ def format_date(
 
             session = googlesql._find_session(
                 format_string,
-                time_zone,
             )
 
         bf_series = self._bf_from_series(session)
         result = format_date_impl(
             format_string,
             bf_series,
-            time_zone,
         )
         return self._to_series(cast(series.Series, result))
 

packages/bigframes/bigframes/operations/googlesql/global_namespace/date.py

@@ -81,7 +81,7 @@
 )
 _FORMAT_DATE_OP = googlesql.GoogleSqlScalarOp(
     "FORMAT_DATE",
-    args=(googlesql.ArgSpec(), googlesql.ArgSpec(), googlesql.ArgSpec(optional=True)),
+    args=(googlesql.ArgSpec(), googlesql.ArgSpec()),
     signature=lambda *args: dtypes.STRING_DTYPE,
 )
 _GENERATE_DATE_ARRAY_OP = googlesql.GoogleSqlScalarOp(
@@ -355,24 +355,14 @@ def format_date(
     date_expr: Union[
         series.Series,
         bigframes.core.col.Expression,
-        Union[
-            Literal[sentinels.Sentinel.ARGUMENT_DEFAULT],
-            datetime.date,
-            datetime.datetime,
-        ],
+        Union[Literal[sentinels.Sentinel.ARGUMENT_DEFAULT], datetime.date],
     ],
-    time_zone: Union[
-        series.Series,
-        bigframes.core.col.Expression,
-        Union[Literal[sentinels.Sentinel.ARGUMENT_DEFAULT], str],
-    ] = sentinels.Sentinel.ARGUMENT_DEFAULT,
 ) -> Union[series.Series, bigframes.core.col.Expression]:
     """Formats a DATE value according to a specified format string."""
     return bigframes.core.googlesql.apply_googlesql_scalar_op(
         _FORMAT_DATE_OP,
         format_string,
         date_expr,
-        time_zone,
     )
 
 

packages/bigframes/scripts/data/sql-functions/global_namespace/date.yaml

@@ -256,32 +256,6 @@ scalar_functions:
             optional: false
             keyword_only: false
         return: string
-      # Signature: format_date:str_pts
-      - args:
-          - name: "format_string"
-            value: string
-            optional: false
-            keyword_only: false
-          - name: "date_expr"
-            value: timestamp
-            optional: false
-            keyword_only: false
-        return: string
-      # Signature: format_date:str_pts_str
-      - args:
-          - name: "format_string"
-            value: string
-            optional: false
-            keyword_only: false
-          - name: "date_expr"
-            value: timestamp
-            optional: false
-            keyword_only: false
-          - name: "time_zone"
-            value: string
-            optional: true
-            keyword_only: false
-        return: string
   - name: "generate_date_array"
     description: "Generates an array of dates in a range."
     impls:

packages/bigframes/tests/unit/bigquery/generated/global_namespace/test_date.py

@@ -253,7 +253,6 @@ def test_format_date_expression():
     result = bbq.format_date(
         bpd.col("format_string"),
         bpd.col("date_expr"),
-        bpd.col("time_zone"),
     )
 
     # Verify result is a col Expression
@@ -265,13 +264,11 @@ def test_format_date_expression():
     assert expr.op == date_op._FORMAT_DATE_OP
 
     # Verify arguments are free variables matching the names
-    assert len(expr.inputs) == 3
+    assert len(expr.inputs) == 2
     assert isinstance(expr.inputs[0], ex.UnboundVariableExpression)
     assert expr.inputs[0].id == "format_string"
     assert isinstance(expr.inputs[1], ex.UnboundVariableExpression)
     assert expr.inputs[1].id == "date_expr"
-    assert isinstance(expr.inputs[2], ex.UnboundVariableExpression)
-    assert expr.inputs[2].id == "time_zone"
 
 
 def test_generate_date_array_expression():