refactor(core): remove duplicate error attribute extraction in favor of method spans

Author: chalmerlowe

packages/google-api-core/google/api_core/_observability.py

@@ -127,43 +127,6 @@ def _extract_grpc_request_attributes(request: Any) -> dict[str, Any]:
     return attrs
 
 
-def _extract_error_attributes(exc: Any) -> dict[str, Any]:
-    """Extracts gcp.errors.domain, gcp.errors.metadata.*, and error.type from an exception or ErrorInfo.
-
-    Args:
-        exc: An exception (such as GoogleAPICallError or grpc.RpcError) or ErrorInfo object.
-
-    Returns:
-        dict[str, Any]: Extracted error attributes.
-    """
-    attrs: dict[str, Any] = {}
-    if exc is None:
-        return attrs
-
-    error_info = getattr(exc, "error_info", None)
-    if error_info is None and hasattr(exc, "trailing_metadata"):
-        try:
-            from google.api_core import exceptions
-
-            _, error_info = exceptions._parse_grpc_error_details(exc)
-        except Exception:
-            pass
-
-    if error_info is not None:
-        domain = getattr(error_info, "domain", None)
-        if domain and isinstance(domain, str):
-            attrs["gcp.errors.domain"] = domain
-        reason = getattr(error_info, "reason", None)
-        if reason and isinstance(reason, str):
-            attrs["error.type"] = reason
-        metadata = getattr(error_info, "metadata", None)
-        if metadata and hasattr(metadata, "items"):
-            for k, v in metadata.items():
-                attrs[f"gcp.errors.metadata.{k}"] = str(v)
-
-    return attrs
-
-
 def _make_grpc_client_request_hook(
     endpoint_attrs: dict[str, Any] | None = None,
 ) -> Callable[[Any, Any], None]:

packages/google-api-core/tests/unit/test_observability.py

@@ -416,83 +416,6 @@ def test_grpc_client_request_hook():
     mock_span_custom.update_name.assert_not_called()
 
 
-def test_extract_error_attributes_none():
-    """Proves that _extract_error_attributes returns an empty dict when exception is None."""
-    assert _observability._extract_error_attributes(None) == {}
-
-
-def test_extract_error_attributes_standard_exception():
-    """Proves that _extract_error_attributes returns an empty dict for standard exceptions without ErrorInfo."""
-    assert (
-        _observability._extract_error_attributes(ValueError("unexpected error")) == {}
-    )
-
-
-def test_extract_error_attributes_with_error_info():
-    """Proves that _extract_error_attributes extracts domain, error.type, and metadata from ErrorInfo."""
-    error_info = types.SimpleNamespace(
-        domain="googleapis.com",
-        reason="SERVICE_DISABLED",
-        metadata={
-            "service": "secretmanager.googleapis.com",
-            "consumer": "projects/123",
-        },
-    )
-    exc = types.SimpleNamespace(error_info=error_info)
-    attrs = _observability._extract_error_attributes(exc)
-    assert attrs == {
-        "gcp.errors.domain": "googleapis.com",
-        "error.type": "SERVICE_DISABLED",
-        "gcp.errors.metadata.service": "secretmanager.googleapis.com",
-        "gcp.errors.metadata.consumer": "projects/123",
-    }
-
-
-def test_extract_error_attributes_from_grpc_trailing_metadata(monkeypatch):
-    """Proves that _extract_error_attributes parses error_info from gRPC trailing metadata."""
-    from google.api_core import exceptions
-
-    mock_exc = mock.Mock()
-    mock_exc.error_info = None
-    mock_exc.trailing_metadata = mock.Mock()
-
-    parsed_error_info = types.SimpleNamespace(
-        domain="googleapis.com",
-        reason="RESOURCE_EXHAUSTED",
-        metadata={"quota_limit": "100"},
-    )
-
-    monkeypatch.setattr(
-        exceptions,
-        "_parse_grpc_error_details",
-        mock.Mock(return_value=(None, parsed_error_info)),
-    )
-
-    attrs = _observability._extract_error_attributes(mock_exc)
-    assert attrs == {
-        "gcp.errors.domain": "googleapis.com",
-        "error.type": "RESOURCE_EXHAUSTED",
-        "gcp.errors.metadata.quota_limit": "100",
-    }
-
-
-def test_extract_error_attributes_trailing_metadata_failure(monkeypatch):
-    """Proves that _extract_error_attributes safely handles exceptions during trailing metadata parsing."""
-    from google.api_core import exceptions
-
-    mock_exc = mock.Mock()
-    mock_exc.error_info = None
-    mock_exc.trailing_metadata = mock.Mock()
-
-    monkeypatch.setattr(
-        exceptions,
-        "_parse_grpc_error_details",
-        mock.Mock(side_effect=RuntimeError("Parse failed")),
-    )
-
-    assert _observability._extract_error_attributes(mock_exc) == {}
-
-
 def test_get_otel_interceptor_with_api_endpoint(monkeypatch):
     """Proves that get_otel_interceptor injects server.address, server.port, and url.domain when api_endpoint is set."""
     monkeypatch.setenv("GOOGLE_SDK_EXPERIMENTAL_PYTHON_TRACING_ENABLED", "true")