Commit 97e42b8
authored
test(spanner): fix AFE server timing metadata failures in prerelease tests (#17970)
The AFE server timing metric header
('x-goog-spanner-enable-afe-server-timing') is enabled by default in
Spanner client helper methods (_helpers.py). Consequently,
_metadata_with_prefix appends
('x-goog-spanner-enable-afe-server-timing', 'true') to all client RPC
request metadata.
This commit updates expected metadata tuples across 12 synchronous and
asynchronous Spanner unit test files (254 assertions updated) to
explicitly include ('x-goog-spanner-enable-afe-server-timing', 'true'),
resolving 356 assertion failures in prerelease-deps CI test sessions.
Thank you for opening a Pull Request! Before submitting your PR, there
are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a
[bug/issue](https://github.com/googleapis/google-cloud-python/issues)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Fixes #<issue_number_goes_here> 🦕1 parent 91ab411 commit 97e42b8
2 files changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| 250 | + | |
250 | 251 | | |
251 | 252 | | |
252 | 253 | | |
| |||
609 | 610 | | |
610 | 611 | | |
611 | 612 | | |
| 613 | + | |
612 | 614 | | |
613 | 615 | | |
614 | 616 | | |
| |||
807 | 809 | | |
808 | 810 | | |
809 | 811 | | |
| 812 | + | |
810 | 813 | | |
811 | 814 | | |
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
0 commit comments