test(gapic): add rigorous assertions to negative and fallback tracing tests

Author: chalmerlowe

packages/google-api-core/tests/unit/gapic/test_method.py

@@ -352,20 +352,40 @@ def test__deduplicate_metadata_tokens(headers, expected):
 
 def test_wrap_method_otel_tracing_disabled(monkeypatch):
     """Proves that when OpenTelemetry tracing is disabled, no span is created."""
-    monkeypatch.setenv("GOOGLE_SDK_EXPERIMENTAL_PYTHON_TRACING_ENABLED", "false")
     mock_target = mock.Mock(return_value="success")
+    mock_trace = mock.Mock()
 
-    with mock.patch(
-        "google.api_core._observability.is_otel_capabilities_enabled",
-        return_value=False,
+    with (
+        mock.patch(
+            "google.api_core._observability.is_otel_capabilities_enabled",
+            return_value=False,
+        ),
+        mock.patch.dict(
+            sys.modules,
+            {
+                "opentelemetry": mock.Mock(trace=mock_trace),
+                "opentelemetry.trace": mock_trace,
+            },
+        ),
     ):
         wrapped = google.api_core.gapic_v1.method.wrap_method(
             mock_target,
             method_name="google.cloud.secretmanager.v1.SecretManagerService/ListSecrets",
         )
-        assert wrapped() == "success"
+        result = wrapped()
+
+    # 1. Prove the RPC executed successfully
+    assert result == "success"
     mock_target.assert_called_once()
 
+    # 2. Prove the OpenTelemetry API was never invoked
+    mock_trace.get_tracer.assert_not_called()
+
+    # 3. Prove the callable holds no tracer or span configuration
+    assert wrapped._tracer is None
+    assert wrapped._span_name is None
+    assert wrapped._span_attributes is None
+
 
 def test_wrap_method_otel_tracing_omitted_method_name_skips_span(monkeypatch):
     """Proves that when method_name is omitted (e.g. streaming or uninstrumented), no span is created."""
@@ -390,9 +410,18 @@ def test_wrap_method_otel_tracing_omitted_method_name_skips_span(monkeypatch):
         wrapped = google.api_core.gapic_v1.method.wrap_method(mock_target)
         result = wrapped()
 
+    # 1. Prove the RPC executed successfully
     assert result == "success"
+    mock_target.assert_called_once()
+
+    # 2. Prove the OpenTelemetry API was never invoked
     mock_trace.get_tracer.assert_not_called()
 
+    # 3. Prove the callable holds no tracer or span configuration
+    assert wrapped._tracer is None
+    assert wrapped._span_name is None
+    assert wrapped._span_attributes is None
+
 
 def test_wrap_method_otel_tracing_streaming_skips_span(monkeypatch):
     """Proves that when is_streaming=True is passed, no Tier 3 span is created."""
@@ -421,9 +450,18 @@ def test_wrap_method_otel_tracing_streaming_skips_span(monkeypatch):
         )
         result = wrapped()
 
+    # 1. Prove the RPC executed successfully
     assert result == "success"
+    mock_target.assert_called_once()
+
+    # 2. Prove the OpenTelemetry API was never invoked
     mock_trace.get_tracer.assert_not_called()
 
+    # 3. Prove the callable holds no tracer or span configuration
+    assert wrapped._tracer is None
+    assert wrapped._span_name is None
+    assert wrapped._span_attributes is None
+
 
 def test_wrap_method_otel_tracing_enabled_success(monkeypatch):
     """Proves that when OpenTelemetry tracing is enabled and method_name is passed, a T3 client span is started."""
@@ -628,9 +666,15 @@ def test_wrap_method_otel_tracing_import_error(monkeypatch):
         )
         result = wrapped()
 
+    # 1. Prove the RPC executed successfully
     assert result == "success"
     mock_target.assert_called_once()
 
+    # 2. Prove the callable holds no tracer or span configuration
+    assert wrapped._tracer is None
+    assert wrapped._span_name is None
+    assert wrapped._span_attributes is None
+
 
 def test_wrap_method_otel_tracing_provider_attribute_error(monkeypatch):
     """Proves that if tracer_provider raises AttributeError, execution proceeds gracefully."""
@@ -654,9 +698,15 @@ def test_wrap_method_otel_tracing_provider_attribute_error(monkeypatch):
         )
         result = wrapped()
 
+    # 1. Prove the RPC executed successfully
     assert result == "success"
     mock_target.assert_called_once()
 
+    # 2. Prove the callable holds no tracer or span configuration
+    assert wrapped._tracer is None
+    assert wrapped._span_name is None
+    assert wrapped._span_attributes is None
+
 
 def test_wrap_method_otel_tracing_provider_type_error(monkeypatch):
     """Proves that if tracer_provider raises TypeError, execution proceeds gracefully."""
@@ -680,9 +730,15 @@ def test_wrap_method_otel_tracing_provider_type_error(monkeypatch):
         )
         result = wrapped()
 
+    # 1. Prove the RPC executed successfully
     assert result == "success"
     mock_target.assert_called_once()
 
+    # 2. Prove the callable holds no tracer or span configuration
+    assert wrapped._tracer is None
+    assert wrapped._span_name is None
+    assert wrapped._span_attributes is None
+
 
 def test_wrap_method_otel_tracing_start_span_error_bypasses_tracing(monkeypatch):
     """Proves that if start_as_current_span raises an Exception, execution proceeds gracefully with nullcontext."""
@@ -804,5 +860,14 @@ def test_wrap_method_async_otel_tracing_streaming_skips_span(monkeypatch):
         )
         result = wrapped()
 
+    # 1. Prove the RPC executed successfully
     assert result == "async_success"
+    mock_target.assert_called_once()
+
+    # 2. Prove the OpenTelemetry API was never invoked
     mock_trace.get_tracer.assert_not_called()
+
+    # 3. Prove the callable holds no tracer or span configuration
+    assert wrapped._tracer is None
+    assert wrapped._span_name is None
+    assert wrapped._span_attributes is None