python: observed generated changes missed in release from legacylibrarian

[zhumin8]

Observed two case of miss:

• The changes included in chore: update googleapis and regenerate google-cloud-python#17383 merged on June 5.

The next release PR merged on June 11 googleapis/google-cloud-python#17432, don't have these libraries

• chore: release main google-cloud-python#17482 created by release please included changes back in May like feat: regenerate google-cloud-[e-i] packages google-cloud-python#17079 and feat: regenerate google-cloud-[o-r] packages google-cloud-python#17075

We should investigate the reason for these misses. More importantly now that we moved away from legacylibrarian, to audit and make sure there are no more missing to release changes in the repo similar to these.

[zhumin8]

Did not find a good milestone for this.
cc. @codyoss

[codyoss]

I created a draft PR to show what was happening here. TLDR; the regex used to parse library ids was too greedy and read from the commit message title. So the commit was associated to a library that does not exists and was silently ignored. I don't think there is more action to take on this bug now that we have moved over to release-please and it has caught and processed affected libraries.

[zhumin8]

Thanks looking into this quickly.

there is more action to take on this bug now that we have moved over to release-please and it has caught and processed affected libraries.

I agree there is no action item for these two cases, as they are caught by release-please.
I do think we should search in recent history and make sure we have no additional misses that code are generated but not released, or if we have similar case in google-cloud-go.

[codyoss]

I think we are good. If there had been such cases release-please would have caught them in Go as well. ( There were not though ) I think we can close out this issue.