Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit to github origin #1

Open
blois opened this issue Oct 27, 2018 · 3 comments
Open

Limit to github origin #1

blois opened this issue Oct 27, 2018 · 3 comments

Comments

@blois
Copy link

blois commented Oct 27, 2018

Should be able to limit the extension to only github URLs with:
https://developer.chrome.com/apps/match_patterns

@jakevdp
Copy link

jakevdp commented Oct 27, 2018

I think it's useful for something to happen when the extension is clicked on a non-github page, otherwise users might think it just doesn't work.

@jakevdp
Copy link

jakevdp commented Oct 29, 2018

Looking into this; if I'm understanding the chrome docs correctly, it looks like match patterns only apply to content scripts, which run with access to the content of the page. This extension uses a background script, so matching patterns do not apply.

@jakevdp
Copy link

jakevdp commented Oct 29, 2018

I think also because this extension uses only the activeTab permission, match patterns are not applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants