Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config #26

Open
tmus opened this issue Jan 2, 2023 · 1 comment
Open

Improve config #26

tmus opened this issue Jan 2, 2023 · 1 comment

Comments

@tmus
Copy link
Member

tmus commented Jan 2, 2023

Allow values other than string? Take a closer look.

@tmus
Copy link
Member Author

tmus commented Jan 6, 2023

Can't decide if config should be global like this.

It's convenient being able to call it anywhere, but is going to be crap for tests etc.

Maybe it should be injected into the container instead.

And then maybe we can have a Laravel-esque Facade concept for config (and other things 👀 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant