feat: add shared volume (#77)

Author: lavkesh

modules/job/config/config.go

@@ -57,12 +57,15 @@ type Container struct {
 	Image             string            `json:"image"`
 	ImagePullPolicy   string            `json:"image_pull_policy,omitempty"`
 	Command           []string          `json:"command,omitempty"`
+	Args              []string          `json:"args,omitempty"`
 	SecretsVolumes    []Secret          `json:"secrets_volumes,omitempty"`
 	ConfigMapsVolumes []ConfigMap       `json:"config_maps_volumes,omitempty"`
 	Limits            UsageSpec         `json:"limits,omitempty"`
 	Requests          UsageSpec         `json:"requests,omitempty"`
 	EnvConfigMaps     []string          `json:"env_config_maps,omitempty"`
 	EnvVariables      map[string]string `json:"env_variables,omitempty"`
+	PreStopCmd        []string          `json:"pre_stop_cmd,omitempty"`
+	PostStartCmd      []string          `json:"post_start_cmd,omitempty"`
 }
 
 type Secret struct {

modules/job/driver/sync.go

@@ -94,9 +94,12 @@ func getJob(res resource.Resource, conf *config.Config) *job.Job {
 			Name:            c.Name,
 			EnvConfigMaps:   c.EnvConfigMaps,
 			Command:         c.Command,
+			Args:            c.Args,
 			EnvMap:          c.EnvVariables,
 			ImagePullPolicy: c.ImagePullPolicy,
 			VolumeMounts:    vm,
+			PreStopCmd:      c.PreStopCmd,
+			PostStartCmd:    c.PostStartCmd,
 			Requests:        map[string]string{"cpu": c.Requests.CPU, "memory": c.Requests.Memory},
 			Limits:          map[string]string{"cpu": c.Limits.CPU, "memory": c.Limits.Memory},
 		})

pkg/kube/container/container.go

@@ -17,6 +17,8 @@ type Container struct {
 	VolumeMounts    []VolumeMount
 	Requests        map[string]string
 	Limits          map[string]string
+	PreStopCmd      []string
+	PostStartCmd    []string
 }
 
 type VolumeMount struct {
@@ -48,6 +50,24 @@ func (c Container) Template() corev1.Container {
 		})
 	}
 
+	// Shared directory for all the containers
+	mounts = append(mounts, corev1.VolumeMount{
+		Name:      "shared-data",
+		MountPath: "/shared",
+	})
+
+	var lifecycle corev1.Lifecycle
+	if len(c.PreStopCmd) > 0 {
+		lifecycle.PreStop = &corev1.LifecycleHandler{
+			Exec: &corev1.ExecAction{Command: c.PreStopCmd},
+		}
+	}
+	if len(c.PostStartCmd) > 0 {
+		lifecycle.PostStart = &corev1.LifecycleHandler{
+			Exec: &corev1.ExecAction{Command: c.PostStartCmd},
+		}
+	}
+
 	return corev1.Container{
 		Name:            c.Name,
 		Image:           c.Image,
@@ -57,6 +77,7 @@ func (c Container) Template() corev1.Container {
 		Env:             env,
 		Resources:       c.parseResources(),
 		VolumeMounts:    mounts,
+		Lifecycle:       &lifecycle,
 		ImagePullPolicy: corev1.PullPolicy(c.ImagePullPolicy),
 	}
 }

pkg/kube/container/container_test.go

@@ -61,7 +61,11 @@ func TestContainer_Template(t *testing.T) {
 					v1.ResourceMemory: quantity,
 				},
 			},
-			VolumeMounts:    []v1.VolumeMount{{Name: "v1", MountPath: "/tmp/v1"}},
+			Lifecycle: &v1.Lifecycle{},
+			VolumeMounts: []v1.VolumeMount{
+				{Name: "v1", MountPath: "/tmp/v1"},
+				{Name: "shared-data", MountPath: "/shared"},
+			},
 			ImagePullPolicy: "Never",
 		}},
 	}
@@ -80,7 +84,7 @@ func TestContainer_Template(t *testing.T) {
 				Limits:          tt.fields.Limits,
 			}
 			if got := c.Template(); !reflect.DeepEqual(got, tt.want) {
-				t.Errorf("Template() = %v, want %v", got, tt.want)
+				t.Errorf("Template() = %v\n, want %v\n", got, tt.want)
 			}
 		})
 	}

pkg/kube/job/job_test.go

@@ -46,8 +46,11 @@ func TestJob_Template(t *testing.T) {
 				Template: v13.PodTemplateSpec{
 					ObjectMeta: v1.ObjectMeta{Name: "pod-name"},
 					Spec: v13.PodSpec{
-						Containers:    nil,
-						Volumes:       nil,
+						Containers: nil,
+						Volumes: []v13.Volume{{
+							Name:         "shared-data",
+							VolumeSource: v13.VolumeSource{EmptyDir: &v13.EmptyDirVolumeSource{}},
+						}},
 						RestartPolicy: v13.RestartPolicyNever,
 					},
 				},

pkg/kube/pod/pod.go

@@ -23,6 +23,10 @@ func (p Pod) Template() corev1.PodTemplateSpec {
 	for _, v := range p.Volumes {
 		volumes = append(volumes, v.GetPodVolume())
 	}
+	volumes = append(volumes, corev1.Volume{
+		Name:         "shared-data",
+		VolumeSource: corev1.VolumeSource{EmptyDir: &corev1.EmptyDirVolumeSource{}},
+	})
 	return corev1.PodTemplateSpec{
 		ObjectMeta: metav1.ObjectMeta{Name: p.Name},
 		Spec: corev1.PodSpec{