Merge pull request #230 from agent3bood/issues/227

[gql_websocket_link] Fix race condition when executing multiple request without await

Author: agent3bood

docs/gql.svg

@@ -1,3 +1,11 @@
+## 0.3.1
+
+- Close [227](https://github.com/gql-dart/gql/issues/227).
+
+## 0.3.0
+
+- Migrate to null safety
+
 ## 0.3.0-nullsafety.1
 
 - Migrate to null safety

links/gql_websocket_link/CHANGELOG.md

@@ -1,6 +1,6 @@
 /// GQL WebSocket link
 library gql_websocket_link;
 
-export "package:gql_websocket_link/src/link.dart";
 export "package:gql_websocket_link/src/exceptions.dart";
+export "package:gql_websocket_link/src/link.dart";
 export "package:gql_websocket_link/src/messages.dart";

links/gql_websocket_link/lib/gql_websocket_link.dart

@@ -1,7 +1,7 @@
 import "package:gql_exec/gql_exec.dart";
 import "package:gql_link/gql_link.dart";
-import "package:meta/meta.dart";
 import "package:gql_websocket_link/gql_websocket_link.dart";
+import "package:meta/meta.dart";
 
 /// Exception occurring when response parsing fails
 @immutable

links/gql_websocket_link/lib/src/exceptions.dart

@@ -1,14 +1,14 @@
 import "dart:async";
 import "dart:convert";
 
-import "package:gql_websocket_link/gql_websocket_link.dart";
 import "package:gql_exec/gql_exec.dart";
 import "package:gql_link/gql_link.dart";
+import "package:gql_websocket_link/gql_websocket_link.dart";
 import "package:meta/meta.dart";
 import "package:rxdart/rxdart.dart";
 import "package:uuid/uuid.dart";
-import "package:web_socket_channel/web_socket_channel.dart";
 import "package:web_socket_channel/status.dart" as websocket_status;
+import "package:web_socket_channel/web_socket_channel.dart";
 
 final uuid = Uuid();
 
@@ -133,7 +133,7 @@ class WebSocketLink extends Link {
     );
     _requests.add(requestWithContext);
 
-    if (_channel == null || _connectionStateController.value == closed) {
+    if (_connectionStateController.value == closed) {
       await _connect();
     }
     final StreamController<Response> response = StreamController();

links/gql_websocket_link/lib/src/link.dart

@@ -1,5 +1,5 @@
 name: gql_websocket_link
-version: 0.3.0
+version: 0.3.1
 description: GQL Websocket Link
 repository: https://github.com/gql-dart/gql
 environment: 

links/gql_websocket_link/pubspec.yaml

@@ -5,8 +5,8 @@ import "dart:io";
 import "package:gql/language.dart";
 import "package:gql_exec/gql_exec.dart";
 import "package:gql_websocket_link/gql_websocket_link.dart";
-import "package:web_socket_channel/io.dart";
 import "package:test/test.dart";
+import "package:web_socket_channel/io.dart";
 import "package:web_socket_channel/status.dart" as websocket_status;
 
 void main() {
@@ -1057,6 +1057,34 @@ void main() {
         );
         link.request(request).listen(print, onError: print);
       });
+
+      test(
+          "_connect() must be called only once when executing multiple requests without awaiting",
+          () async {
+        WebSocketLink link;
+        Request request;
+
+        request = Request(
+          operation: Operation(
+            operationName: "sub",
+            document: parseString("subscription MySubscription {}"),
+          ),
+        );
+
+        link = WebSocketLink(
+          null,
+          channelGenerator: expectAsync0(
+            () async => IOWebSocketChannel.connect("ws://localhost"),
+            count: 1,
+            max: 1,
+          ),
+        );
+
+        link.request(request).listen((event) {});
+        link.request(request).listen((event) {});
+        link.request(request).listen((event) {});
+        link.request(request).listen((event) {});
+      });
     },
   );
 }