Skip to content

Update to new upcoming fax API #16

@gehring

Description

@gehring

We've made some pretty big changes to fax which will break neos. We'll be updating pypi with a new release soon but I wanted to offer to help update to the new simpler api (assuming this project is still in development). I was going to go straight for a PR but I noticed that the neos.fit module has some issues that I don't think I can properly fix without a bit of help.

The current implementation in neos.fit never allows the adam optimizer to update its state. Specifically, it always uses freshly initialized internal parameters for its scaling and momentum terms. If someone can help me better understand what constrained_bestfit_minimized is doing, I can submit a PR to both fix the bug and update to the new API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions