Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow UI: Show a graph of the components loaded by modules #275

Open
ptodev opened this issue Jan 16, 2024 · 5 comments · May be fixed by grafana/agent#6378
Open

Flow UI: Show a graph of the components loaded by modules #275

ptodev opened this issue Jan 16, 2024 · 5 comments · May be fixed by grafana/agent#6378
Labels
enhancement New feature or request

Comments

@ptodev
Copy link
Contributor

ptodev commented Jan 16, 2024

Request

If you load a module using a component such as module.string, the UI does not show the sub-graph which module.string loaded, with all of its internal Flow components. It would be nice if this is visible in the UI.

Use case

Ease of use.

@ptodev ptodev added the enhancement New feature or request label Jan 16, 2024
@hainenber
Copy link
Contributor

I could tackle this. Please help assign 😄

@ptodev
Copy link
Contributor Author

ptodev commented Jan 16, 2024

Hi @hainenber! Thank you so much, but there are a couple of problems with this task:

  • It might be a lot of work. Or it might not. I really don't know 😅
  • I am not sure what the UI should look like when modules are visualised.
    • Should the sub graph be displayed inside the module component's box? This would seem most natural.
    • Alternatively, maybe it can be displayed on the side, or in a different location on the page (e.g. in a tab)? This could potentially be an easier implementation.
    • It would be good to get consensus from the team before tackling this.
  • If this is a lot of work, then it would be best to see if we want to tackle Flow UI: Look into a React library for D3 replacement #514 first.

I put in a comment on #514 to ask why it's even raised in the first place. Let's wait for now, to see what the reply is. If #514 is really important, maybe it's be best not to invest too much time in the current visualisation. In that case we'd have to tackle #275 after #514.

@hainenber
Copy link
Contributor

Aight, thanks for the heads up!

I'll try making a PoC to gauge feedbacks firstly then.

Maybe not assign me that early 🤭

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@hainenber
Copy link
Contributor

I've drafted a PoC in the linked PR

There would be a new Graph option on left side
image

, which redirects to a new page depicting the graph
image

Wdyt?

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants