Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veneers: Use the same Datasource struct in all datasources. #554

Open
spinillos opened this issue Sep 17, 2024 · 0 comments · May be fixed by #560
Open

Veneers: Use the same Datasource struct in all datasources. #554

spinillos opened this issue Sep 17, 2024 · 0 comments · May be fixed by #560

Comments

@spinillos
Copy link
Member

spinillos commented Sep 17, 2024

We have the Datasource defined in dashboard, testdata schemas, when it should be the same.

In most of the datasources, this struct isn't pointing to this struct, its an any instead, for example tempo or parca

We need to create a veneer to have this struct in all datasources and point to the same struct. The dashboard, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant